Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 6341004: More net/ reordering. (Closed)

Created:
9 years, 11 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., pam+watch_chromium.org
Visibility:
Public.

Description

More net/ reordering. In addition to the normal method reordering, this patch also deinlines net/base/test_completion_callback.h and places the compiled code in the net_test_support target. Minimization of that header also required adding includes in a few unit tests. BUG=68682 TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72162

Patch Set 1 #

Patch Set 2 : Add headers #

Patch Set 3 : Window gyp dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1239 lines, -1128 lines) Patch
M net/base/file_stream_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/registry_controlled_domain.cc View 3 chunks +35 lines, -31 lines 0 comments Download
M net/base/test_completion_callback.h View 2 chunks +5 lines, -29 lines 0 comments Download
A net/base/test_completion_callback.cc View 1 chunk +40 lines, -0 lines 0 comments Download
M net/base/test_completion_callback_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M net/http/http_auth_handler_factory.h View 2 chunks +5 lines, -5 lines 0 comments Download
M net/http/http_cache.h View 2 chunks +1 line, -1 line 0 comments Download
M net/http/http_proxy_client_socket_pool.h View 2 chunks +9 lines, -9 lines 0 comments Download
M net/http/http_proxy_client_socket_pool.cc View 3 chunks +37 lines, -37 lines 0 comments Download
M net/net.gyp View 1 2 3 chunks +3 lines, -1 line 0 comments Download
M net/proxy/multi_threaded_proxy_resolver_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/socket/socket_test_util.h View 21 chunks +98 lines, -94 lines 0 comments Download
M net/socket/socket_test_util.cc View 5 chunks +807 lines, -752 lines 0 comments Download
M net/socket/socks_client_socket_pool.h View 2 chunks +5 lines, -5 lines 0 comments Download
M net/socket/socks_client_socket_pool.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M net/socket/ssl_client_socket_pool.h View 2 chunks +5 lines, -5 lines 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 6 chunks +42 lines, -42 lines 0 comments Download
M net/spdy/spdy_session.h View 5 chunks +24 lines, -24 lines 0 comments Download
M net/spdy/spdy_test_util.h View 2 chunks +11 lines, -87 lines 0 comments Download
M net/spdy/spdy_test_util.cc View 1 chunk +96 lines, -0 lines 0 comments Download
M net/test/test_server.h View 2 chunks +2 lines, -1 line 0 comments Download
M net/test/test_server.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/dump_cache/upgrade.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/url_request/view_cache_helper_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/database/database_tracker_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Elliot Glaysher
9 years, 11 months ago (2011-01-21 02:26:17 UTC) #1
willchan no longer on Chromium
9 years, 11 months ago (2011-01-21 02:33:14 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698