More net/ reordering.

net/spdy/spdy_test_util.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SPDY_SPDY_TEST_UTIL_H_
 #define NET_SPDY_SPDY_TEST_UTIL_H_
 #pragma once
 
 #include "base/basictypes.h"
 #include "net/base/cert_verifier.h"
@@ skipping 308 matching lines @@
 // Combines the given SpdyFrames into the given char array and returns
 // the total length.
 int CombineFrames(const spdy::SpdyFrame** frames, int num_frames,
                   char* buff, int buff_len);
 
 // Helper to manage the lifetimes of the dependencies for a
 // HttpNetworkTransaction.
 class SpdySessionDependencies {
  public:
   // Default set of dependencies -- "null" proxy service.
-  SpdySessionDependencies()
-      : host_resolver(new MockHostResolver),
-        cert_verifier(new CertVerifier),
-        proxy_service(ProxyService::CreateDirect()),
-        ssl_config_service(new SSLConfigServiceDefaults),
-        socket_factory(new MockClientSocketFactory),
-        deterministic_socket_factory(new DeterministicMockClientSocketFactory),
-        http_auth_handler_factory(
-            HttpAuthHandlerFactory::CreateDefault(host_resolver.get())) {
-          // Note: The CancelledTransaction test does cleanup by running all
-          // tasks in the message loop (RunAllPending).  Unfortunately, that
-          // doesn't clean up tasks on the host resolver thread; and
-          // TCPConnectJob is currently not cancellable.  Using synchronous
-          // lookups allows the test to shutdown cleanly.  Until we have
-          // cancellable TCPConnectJobs, use synchronous lookups.
-          host_resolver->set_synchronous_mode(true);
-        }
+  SpdySessionDependencies();
 
   // Custom proxy service dependency.
-  explicit SpdySessionDependencies(ProxyService* proxy_service)
-      : host_resolver(new MockHostResolver),
-        cert_verifier(new CertVerifier),
-        proxy_service(proxy_service),
-        ssl_config_service(new SSLConfigServiceDefaults),
-        socket_factory(new MockClientSocketFactory),
-        deterministic_socket_factory(new DeterministicMockClientSocketFactory),
-        http_auth_handler_factory(
-            HttpAuthHandlerFactory::CreateDefault(host_resolver.get())) {}
+  explicit SpdySessionDependencies(ProxyService* proxy_service);
+
+  ~SpdySessionDependencies();
+
+  static HttpNetworkSession* SpdyCreateSession(
+      SpdySessionDependencies* session_deps);
+  static HttpNetworkSession* SpdyCreateSessionDeterministic(
+      SpdySessionDependencies* session_deps);
 
   // NOTE: host_resolver must be ordered before http_auth_handler_factory.
   scoped_ptr<MockHostResolverBase> host_resolver;
   scoped_ptr<CertVerifier> cert_verifier;
   scoped_refptr<ProxyService> proxy_service;
   scoped_refptr<SSLConfigService> ssl_config_service;
   scoped_ptr<MockClientSocketFactory> socket_factory;
   scoped_ptr<DeterministicMockClientSocketFactory> deterministic_socket_factory;
   scoped_ptr<HttpAuthHandlerFactory> http_auth_handler_factory;
-
-  static HttpNetworkSession* SpdyCreateSession(
-      SpdySessionDependencies* session_deps) {
-    return new HttpNetworkSession(session_deps->host_resolver.get(),
-                                  session_deps->cert_verifier.get(),
-                                  NULL /* dnsrr_resolver */,
-                                  NULL /* dns_cert_checker */,
-                                  NULL /* ssl_host_info_factory */,
-                                  session_deps->proxy_service,
-                                  session_deps->socket_factory.get(),
-                                  session_deps->ssl_config_service,
-                                  new SpdySessionPool(NULL),
-                                  session_deps->http_auth_handler_factory.get(),
-                                  NULL,
-                                  NULL);
-  }
-  static HttpNetworkSession* SpdyCreateSessionDeterministic(
-      SpdySessionDependencies* session_deps) {
-    return new HttpNetworkSession(session_deps->host_resolver.get(),
-                                  session_deps->cert_verifier.get(),
-                                  NULL /* dnsrr_resolver */,
-                                  NULL /* dns_cert_checker */,
-                                  NULL /* ssl_host_info_factory */,
-                                  session_deps->proxy_service,
-                                  session_deps->
-                                      deterministic_socket_factory.get(),
-                                  session_deps->ssl_config_service,
-                                  new SpdySessionPool(NULL),
-                                  session_deps->http_auth_handler_factory.get(),
-                                  NULL,
-                                  NULL);
-  }
 };
 
 class SpdyURLRequestContext : public URLRequestContext {
  public:
-  SpdyURLRequestContext() {
-    host_resolver_ = new MockHostResolver();
-    cert_verifier_ = new CertVerifier;
-    proxy_service_ = ProxyService::CreateDirect();
-    ssl_config_service_ = new SSLConfigServiceDefaults;
-    http_auth_handler_factory_ = HttpAuthHandlerFactory::CreateDefault(
-        host_resolver_);
-    http_transaction_factory_ = new HttpCache(
-        new HttpNetworkLayer(&socket_factory_,
-                             host_resolver_,
-                             cert_verifier_,
-                             NULL /* dnsrr_resolver */,
-                             NULL /* dns_cert_checker */,
-                             NULL /* ssl_host_info_factory */,
-                             proxy_service_,
-                             ssl_config_service_,
-                             new SpdySessionPool(NULL),
-                             http_auth_handler_factory_,
-                             network_delegate_,
-                             NULL),
-        NULL /* net_log */,
-        HttpCache::DefaultBackend::InMemory(0));
-  }
+  SpdyURLRequestContext();
 
   MockClientSocketFactory& socket_factory() { return socket_factory_; }
 
  protected:
-  virtual ~SpdyURLRequestContext() {
-    delete http_transaction_factory_;
-    delete http_auth_handler_factory_;
-    delete cert_verifier_;
-    delete host_resolver_;
-  }
+  virtual ~SpdyURLRequestContext();
 
  private:
   MockClientSocketFactory socket_factory_;
 };
 
 const SpdyHeaderInfo make_spdy_header(spdy::SpdyControlType type);
 }  // namespace net
 
 #endif  // NET_SPDY_SPDY_TEST_UTIL_H_