[Mac] Consolidate all files relating to preferences in a subdir of c/b/ui/coc...

[Mac] Consolidate all files relating to preferences in a subdir of c/b/ui/cocoa/

BUG=none
TEST=compile and trybots

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71502

[Robert Sesek, 2011-01-14 18:16:24]

Here's one for you, too.

[Nico, 2011-01-14 18:34:45]

Should this folder be called "options" instead of "preferences" for consistency
with c/b/u/gtk/options and c/b/ui/views/options?

(I'm pretty sure the answer is "yes", but I agree it's a bit weird.)

[Robert Sesek, 2011-01-14 18:36:34]

On 2011/01/14 18:34:45, Nico wrote:
> Should this folder be called "options" instead of "preferences" for
consistency
> with c/b/u/gtk/options and c/b/ui/views/options?
> 
> (I'm pretty sure the answer is "yes", but I agree it's a bit weird.)

I thought about it, but on Mac we call it preferences
(PreferencesWindowController, for example). It won't matter for very long,
though; I'm just doing this to make ripping out native prefs easier ;).

[Nico, 2011-01-14 18:39:58]

On Fri, Jan 14, 2011 at 10:36 AM,  <rsesek@chromium.org> wrote:
> On 2011/01/14 18:34:45, Nico wrote:
>>
>> Should this folder be called "options" instead of "preferences" for
>
> consistency
>>
>> with c/b/u/gtk/options and c/b/ui/views/options?
>
>> (I'm pretty sure the answer is "yes", but I agree it's a bit weird.)
>
> I thought about it, but on Mac we call it preferences
> (PreferencesWindowController, for example). It won't matter for very long,
> though; I'm just doing this to make ripping out native prefs easier ;).

Ah, right :-/ LG then.

>
> http://codereview.chromium.org/6339002/
>

[Robert Sesek, 2011-01-14 19:13:42]

Per IRC, using options/ instead.

[Nico, 2011-01-14 19:17:57]

http://codereview.chromium.org/6339002/diff/22001/chrome/browser/ui/cocoa/opt...
File chrome/browser/ui/cocoa/options/cookies_window_controller_unittest.mm
(right):

http://codereview.chromium.org/6339002/diff/22001/chrome/browser/ui/cocoa/opt...
chrome/browser/ui/cocoa/options/cookies_window_controller_unittest.mm:65:
indexed_db_helper_ = new MockBrowsingDataIndexedDBHelper(profile);
looks unrelated?

[Robert Sesek, 2011-01-14 19:19:39]

On 2011/01/14 19:17:57, Nico wrote:
>
http://codereview.chromium.org/6339002/diff/22001/chrome/browser/ui/cocoa/opt...
> File chrome/browser/ui/cocoa/options/cookies_window_controller_unittest.mm
> (right):
> 
>
http://codereview.chromium.org/6339002/diff/22001/chrome/browser/ui/cocoa/opt...
> chrome/browser/ui/cocoa/options/cookies_window_controller_unittest.mm:65:
> indexed_db_helper_ = new MockBrowsingDataIndexedDBHelper(profile);
> looks unrelated?

Someone removed this file from the gypi so when people made changes, they didn't
see any breakage. I just brought it up to date.

[Nico, 2011-01-14 19:20:14]

LG