Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Side by Side Diff: chrome/browser/ui/cocoa/edit_search_engine_cocoa_controller_unittest.mm

Issue 6339002: [Mac] Consolidate all files relating to preferences in a subdir of c/b/ui/coc... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "app/l10n_util_mac.h"
6 #include "base/scoped_nsobject.h"
7 #include "chrome/browser/search_engines/template_url.h"
8 #include "chrome/browser/ui/cocoa/browser_test_helper.h"
9 #include "chrome/browser/ui/cocoa/cocoa_test_helper.h"
10 #import "chrome/browser/ui/cocoa/edit_search_engine_cocoa_controller.h"
11 #include "chrome/test/testing_profile.h"
12 #include "grit/generated_resources.h"
13 #include "testing/gtest/include/gtest/gtest.h"
14 #import "testing/gtest_mac.h"
15 #include "testing/platform_test.h"
16
17 @interface FakeEditSearchEngineController : EditSearchEngineCocoaController {
18 }
19 @property (nonatomic, readonly) NSTextField* nameField;
20 @property (nonatomic, readonly) NSTextField* keywordField;
21 @property (nonatomic, readonly) NSTextField* urlField;
22 @property (nonatomic, readonly) NSImageView* nameImage;
23 @property (nonatomic, readonly) NSImageView* keywordImage;
24 @property (nonatomic, readonly) NSImageView* urlImage;
25 @property (nonatomic, readonly) NSButton* doneButton;
26 @property (nonatomic, readonly) NSImage* goodImage;
27 @property (nonatomic, readonly) NSImage* badImage;
28 @end
29
30 @implementation FakeEditSearchEngineController
31 @synthesize nameField = nameField_;
32 @synthesize keywordField = keywordField_;
33 @synthesize urlField = urlField_;
34 @synthesize nameImage = nameImage_;
35 @synthesize keywordImage = keywordImage_;
36 @synthesize urlImage = urlImage_;
37 @synthesize doneButton = doneButton_;
38 - (NSImage*)goodImage {
39 return goodImage_.get();
40 }
41 - (NSImage*)badImage {
42 return badImage_.get();
43 }
44 @end
45
46 namespace {
47
48 class EditSearchEngineControllerTest : public CocoaTest {
49 public:
50 virtual void SetUp() {
51 CocoaTest::SetUp();
52 TestingProfile* profile =
53 static_cast<TestingProfile*>(browser_helper_.profile());
54 profile->CreateTemplateURLModel();
55 controller_ = [[FakeEditSearchEngineController alloc]
56 initWithProfile:profile
57 delegate:nil
58 templateURL:nil];
59 }
60
61 virtual void TearDown() {
62 // Force the window to load so we hit |-awakeFromNib| to register as the
63 // window's delegate so that the controller can clean itself up in
64 // |-windowWillClose:|.
65 ASSERT_TRUE([controller_ window]);
66
67 [controller_ close];
68 CocoaTest::TearDown();
69 }
70
71 BrowserTestHelper browser_helper_;
72 FakeEditSearchEngineController* controller_;
73 };
74
75 TEST_F(EditSearchEngineControllerTest, ValidImageOriginals) {
76 EXPECT_FALSE([controller_ goodImage]);
77 EXPECT_FALSE([controller_ badImage]);
78
79 EXPECT_TRUE([controller_ window]); // Force the window to load.
80
81 EXPECT_TRUE([[controller_ goodImage] isKindOfClass:[NSImage class]]);
82 EXPECT_TRUE([[controller_ badImage] isKindOfClass:[NSImage class]]);
83
84 // Test window title is set correctly.
85 NSString* title = l10n_util::GetNSString(
86 IDS_SEARCH_ENGINES_EDITOR_NEW_WINDOW_TITLE);
87 EXPECT_NSEQ(title, [[controller_ window] title]);
88 }
89
90 TEST_F(EditSearchEngineControllerTest, SetImageViews) {
91 EXPECT_TRUE([controller_ window]); // Force the window to load.
92 EXPECT_EQ([controller_ badImage], [[controller_ nameImage] image]);
93 // An empty keyword is not OK.
94 EXPECT_EQ([controller_ badImage], [[controller_ keywordImage] image]);
95 EXPECT_EQ([controller_ badImage], [[controller_ urlImage] image]);
96 }
97
98 // This test ensures that on creating a new keyword, we are in an "invalid"
99 // state that cannot save.
100 TEST_F(EditSearchEngineControllerTest, InvalidState) {
101 EXPECT_TRUE([controller_ window]); // Force window to load.
102 NSString* toolTip = nil;
103 EXPECT_FALSE([controller_ validateFields]);
104
105 EXPECT_NSEQ(@"", [[controller_ nameField] stringValue]);
106 EXPECT_EQ([controller_ badImage], [[controller_ nameImage] image]);
107 toolTip = l10n_util::GetNSString(IDS_SEARCH_ENGINES_INVALID_TITLE_TT);
108 EXPECT_NSEQ(toolTip, [[controller_ nameField] toolTip]);
109 EXPECT_NSEQ(toolTip, [[controller_ nameImage] toolTip]);
110
111 // Keywords can not be empty strings.
112 EXPECT_NSEQ(@"", [[controller_ keywordField] stringValue]);
113 EXPECT_EQ([controller_ badImage], [[controller_ keywordImage] image]);
114 EXPECT_TRUE([[controller_ keywordField] toolTip]);
115 EXPECT_TRUE([[controller_ keywordImage] toolTip]);
116
117 EXPECT_NSEQ(@"", [[controller_ urlField] stringValue]);
118 EXPECT_EQ([controller_ badImage], [[controller_ urlImage] image]);
119 toolTip = l10n_util::GetNSString(IDS_SEARCH_ENGINES_INVALID_URL_TT);
120 EXPECT_NSEQ(toolTip, [[controller_ urlField] toolTip]);
121 EXPECT_NSEQ(toolTip, [[controller_ urlImage] toolTip]);
122 }
123
124 // Tests that the single name field validates.
125 TEST_F(EditSearchEngineControllerTest, ValidateName) {
126 EXPECT_TRUE([controller_ window]); // Force window to load.
127
128 EXPECT_EQ([controller_ badImage], [[controller_ nameImage] image]);
129 EXPECT_FALSE([controller_ validateFields]);
130 NSString* toolTip =
131 l10n_util::GetNSString(IDS_SEARCH_ENGINES_INVALID_TITLE_TT);
132 EXPECT_NSEQ(toolTip, [[controller_ nameField] toolTip]);
133 EXPECT_NSEQ(toolTip, [[controller_ nameImage] toolTip]);
134 [[controller_ nameField] setStringValue:@"Test Name"];
135 EXPECT_FALSE([controller_ validateFields]);
136 EXPECT_EQ([controller_ goodImage], [[controller_ nameImage] image]);
137 EXPECT_FALSE([[controller_ nameField] toolTip]);
138 EXPECT_FALSE([[controller_ nameImage] toolTip]);
139 EXPECT_FALSE([[controller_ doneButton] isEnabled]);
140 }
141
142 // The keyword field is not valid if it is empty.
143 TEST_F(EditSearchEngineControllerTest, ValidateKeyword) {
144 EXPECT_TRUE([controller_ window]); // Force window load.
145
146 EXPECT_EQ([controller_ badImage], [[controller_ keywordImage] image]);
147 EXPECT_FALSE([controller_ validateFields]);
148 EXPECT_TRUE([[controller_ keywordField] toolTip]);
149 EXPECT_TRUE([[controller_ keywordImage] toolTip]);
150 [[controller_ keywordField] setStringValue:@"foobar"];
151 EXPECT_FALSE([controller_ validateFields]);
152 EXPECT_EQ([controller_ goodImage], [[controller_ keywordImage] image]);
153 EXPECT_FALSE([[controller_ keywordField] toolTip]);
154 EXPECT_FALSE([[controller_ keywordImage] toolTip]);
155 EXPECT_FALSE([[controller_ doneButton] isEnabled]);
156 }
157
158 // Tests that the URL field validates.
159 TEST_F(EditSearchEngineControllerTest, ValidateURL) {
160 EXPECT_TRUE([controller_ window]); // Force window to load.
161
162 EXPECT_EQ([controller_ badImage], [[controller_ urlImage] image]);
163 EXPECT_FALSE([controller_ validateFields]);
164 NSString* toolTip =
165 l10n_util::GetNSString(IDS_SEARCH_ENGINES_INVALID_URL_TT);
166 EXPECT_NSEQ(toolTip, [[controller_ urlField] toolTip]);
167 EXPECT_NSEQ(toolTip, [[controller_ urlImage] toolTip]);
168 [[controller_ urlField] setStringValue:@"http://foo-bar.com"];
169 EXPECT_FALSE([controller_ validateFields]);
170 EXPECT_EQ([controller_ goodImage], [[controller_ urlImage] image]);
171 EXPECT_FALSE([[controller_ urlField] toolTip]);
172 EXPECT_FALSE([[controller_ urlImage] toolTip]);
173 EXPECT_FALSE([[controller_ doneButton] isEnabled]);
174 }
175
176 // Tests that if the user enters all valid data that the UI reflects that
177 // and that they can save.
178 TEST_F(EditSearchEngineControllerTest, ValidateFields) {
179 EXPECT_TRUE([controller_ window]); // Force window to load.
180
181 // State before entering data.
182 EXPECT_EQ([controller_ badImage], [[controller_ nameImage] image]);
183 EXPECT_EQ([controller_ badImage], [[controller_ keywordImage] image]);
184 EXPECT_EQ([controller_ badImage], [[controller_ urlImage] image]);
185 EXPECT_FALSE([[controller_ doneButton] isEnabled]);
186 EXPECT_FALSE([controller_ validateFields]);
187
188 [[controller_ nameField] setStringValue:@"Test Name"];
189 EXPECT_FALSE([controller_ validateFields]);
190 EXPECT_EQ([controller_ goodImage], [[controller_ nameImage] image]);
191 EXPECT_FALSE([[controller_ doneButton] isEnabled]);
192
193 [[controller_ keywordField] setStringValue:@"foobar"];
194 EXPECT_FALSE([controller_ validateFields]);
195 EXPECT_EQ([controller_ goodImage], [[controller_ keywordImage] image]);
196 EXPECT_FALSE([[controller_ doneButton] isEnabled]);
197
198 // Once the URL is entered, we should have all 3 valid fields.
199 [[controller_ urlField] setStringValue:@"http://foo-bar.com"];
200 EXPECT_TRUE([controller_ validateFields]);
201 EXPECT_EQ([controller_ goodImage], [[controller_ urlImage] image]);
202 EXPECT_TRUE([[controller_ doneButton] isEnabled]);
203 }
204
205 // Tests editing an existing TemplateURL.
206 TEST_F(EditSearchEngineControllerTest, EditTemplateURL) {
207 TemplateURL url;
208 url.set_short_name(L"Foobar");
209 url.set_keyword(L"keyword");
210 std::string urlString = TemplateURLRef::DisplayURLToURLRef(
211 L"http://foo-bar.com");
212 url.SetURL(urlString, 0, 1);
213 TestingProfile* profile = browser_helper_.profile();
214 FakeEditSearchEngineController *controller =
215 [[FakeEditSearchEngineController alloc] initWithProfile:profile
216 delegate:nil
217 templateURL:&url];
218 EXPECT_TRUE([controller window]);
219 NSString* title = l10n_util::GetNSString(
220 IDS_SEARCH_ENGINES_EDITOR_EDIT_WINDOW_TITLE);
221 EXPECT_NSEQ(title, [[controller window] title]);
222 NSString* nameString = [[controller nameField] stringValue];
223 EXPECT_NSEQ(@"Foobar", nameString);
224 NSString* keywordString = [[controller keywordField] stringValue];
225 EXPECT_NSEQ(@"keyword", keywordString);
226 NSString* urlValueString = [[controller urlField] stringValue];
227 EXPECT_NSEQ(@"http://foo-bar.com", urlValueString);
228 EXPECT_TRUE([controller validateFields]);
229 [controller close];
230 }
231
232 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698