net: Remove typedef net::URLRequestContext URLRequestContext;

net: Remove typedef net::URLRequestContext URLRequestContext;

BUG=64263
TEST=compiled locally, trybots

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71522

[tfarina, 2011-01-13 23:48:15]

Please, take a look.

[willchan no longer on Chromium, 2011-01-14 15:28:56]

Rubberstamp LGTM

On Thu, Jan 13, 2011 at 3:48 PM, <tfarina@chromium.org> wrote:

> Reviewers: willchan, wtc,
>
> Message:
> Please, take a look.
>
> Description:
> net: Remove typedef net::URLRequestContext URLRequestContext;
>
> BUG=64263
> TEST=compiled locally, trybots
>
> Please review this at http://codereview.chromium.org/6338002/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  chrome/browser/appcache/appcache_dispatcher_host.h
>  M chrome/browser/appcache/appcache_dispatcher_host.cc
>  chrome/browser/appcache/view_appcache_internals_job_factory.cc
>  chrome/browser/browser_child_process_host.h
>  chrome/browser/chrome_plugin_browsing_context.h
>  chrome/browser/chrome_plugin_browsing_context.cc
>  M chrome/browser/chrome_plugin_host.cc
>  M chrome/browser/chrome_plugin_unittest.cc
>  M chrome/browser/dom_ui/net_internals_ui.cc
>  M chrome/browser/download/download_util.cc
>  M chrome/browser/download/save_file_manager.cc
>  M chrome/browser/file_system/file_system_dispatcher_host.h
>  M chrome/browser/io_thread.cc
>  chrome/browser/plugin_process_host.cc
>  chrome/browser/policy/device_management_service.cc
>  M chrome/browser/profiles/profile_impl.cc
>  chrome/browser/renderer_host/browser_render_process_host.cc
>  chrome/browser/renderer_host/pepper_message_filter.cc
>  chrome/browser/renderer_host/render_message_filter.h
>  chrome/browser/renderer_host/render_message_filter.cc
>  chrome/browser/renderer_host/resource_dispatcher_host.cc
>  chrome/browser/renderer_host/resource_message_filter.h
>  chrome/browser/renderer_host/resource_message_filter.cc
>  chrome/browser/renderer_host/socket_stream_dispatcher_host.h
>  chrome/browser/renderer_host/socket_stream_dispatcher_host.cc
>  M chrome/browser/renderer_host/socket_stream_host.cc
>  chrome/browser/speech/speech_recognition_request.cc
>  chrome/browser/sync/glue/http_bridge.h
>  chrome/browser/sync/glue/http_bridge.cc
>  chrome/browser/sync/glue/http_bridge_unittest.cc
>  M chrome/browser/ui/cocoa/browser_test_helper.h
>  M chrome/browser/worker_host/worker_process_host.h
>  chrome/browser/worker_host/worker_process_host.cc
>  chrome/common/notification_type.h
>  chrome/common/render_messages_params.h
>  M chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc
>  chrome/test/plugin/plugin_test.cpp
>  M chrome/test/testing_profile.cc
>  M chrome_frame/metrics_service.cc
>  chrome_frame/test/test_server_test.cc
>  net/proxy/init_proxy_resolver_unittest.cc
>  M net/proxy/proxy_script_fetcher.h
>  M net/proxy/proxy_script_fetcher_impl.h
>  M net/proxy/proxy_script_fetcher_impl.cc
>  net/proxy/proxy_script_fetcher_impl_unittest.cc
>  M net/proxy/proxy_service_unittest.cc
>  M net/socket_stream/socket_stream.h
>  net/socket_stream/socket_stream.cc
>  M net/socket_stream/socket_stream_job.h
>  net/spdy/spdy_test_util.h
>  net/url_request/url_request_context.h
>  M net/url_request/url_request_unittest.h
>  M net/url_request/url_request_unittest.cc
>  M net/url_request/view_cache_helper_unittest.cc
>  M net/websockets/websocket_job_unittest.cc
>  M webkit/appcache/appcache_update_job_unittest.cc
>  webkit/fileapi/file_system_operation.cc
>  webkit/fileapi/sandboxed_file_system_operation.cc
>  M webkit/tools/test_shell/simple_file_writer.cc
>  M webkit/tools/test_shell/simple_socket_stream_bridge.cc
>  webkit/tools/test_shell/test_shell_request_context.h
>
>
>

[wtc, 2011-01-15 17:54:23]

I only reviewed your changes to the 'net' directory.
Most of those changes should be reverted, because the code
is already in the 'net' namespace.

http://codereview.chromium.org/6338002/diff/10001/net/proxy/init_proxy_resolv...
File net/proxy/init_proxy_resolver_unittest.cc (right):

http://codereview.chromium.org/6338002/diff/10001/net/proxy/init_proxy_resolv...
net/proxy/init_proxy_resolver_unittest.cc:110: virtual net::URLRequestContext*
GetRequestContext() { return NULL; }
Undo the changes to this file because it's already in the
'net' namespace.

http://codereview.chromium.org/6338002/diff/10001/net/proxy/proxy_script_fetc...
File net/proxy/proxy_script_fetcher.h (right):

http://codereview.chromium.org/6338002/diff/10001/net/proxy/proxy_script_fetc...
net/proxy/proxy_script_fetcher.h:52: virtual net::URLRequestContext*
GetRequestContext() = 0;
Undo this change (already in the 'net' namespace).

http://codereview.chromium.org/6338002/diff/10001/net/proxy/proxy_script_fetc...
File net/proxy/proxy_script_fetcher_impl.cc (right):

http://codereview.chromium.org/6338002/diff/10001/net/proxy/proxy_script_fetc...
net/proxy/proxy_script_fetcher_impl.cc:73: net::URLRequestContext*
url_request_context)
Undo the changes to this file (already in the 'net' namespace).

http://codereview.chromium.org/6338002/diff/10001/net/proxy/proxy_script_fetc...
File net/proxy/proxy_script_fetcher_impl.h (right):

http://codereview.chromium.org/6338002/diff/10001/net/proxy/proxy_script_fetc...
net/proxy/proxy_script_fetcher_impl.h:36: explicit
ProxyScriptFetcherImpl(net::URLRequestContext* url_request_context);
Undo the changes to this file, because it's already in the
'net' namespace.

http://codereview.chromium.org/6338002/diff/10001/net/proxy/proxy_script_fetc...
File net/proxy/proxy_script_fetcher_impl_unittest.cc (right):

http://codereview.chromium.org/6338002/diff/10001/net/proxy/proxy_script_fetc...
net/proxy/proxy_script_fetcher_impl_unittest.cc:63: namespace net {
The 'net' namespace starts here.  Undo the changes after
this point.

http://codereview.chromium.org/6338002/diff/10001/net/proxy/proxy_service_uni...
File net/proxy/proxy_service_unittest.cc (right):

http://codereview.chromium.org/6338002/diff/10001/net/proxy/proxy_service_uni...
net/proxy/proxy_service_unittest.cc:101: virtual net::URLRequestContext*
GetRequestContext() { return NULL; }
Undo this change (already in the 'net' namespace).

http://codereview.chromium.org/6338002/diff/10001/net/socket_stream/socket_st...
File net/socket_stream/socket_stream.cc (right):

http://codereview.chromium.org/6338002/diff/10001/net/socket_stream/socket_st...
net/socket_stream/socket_stream.cc:99: void
SocketStream::set_context(net::URLRequestContext* context) {
Undo the changes in this file (already in the 'net' namespace).

http://codereview.chromium.org/6338002/diff/10001/net/socket_stream/socket_st...
File net/socket_stream/socket_stream.h (right):

http://codereview.chromium.org/6338002/diff/10001/net/socket_stream/socket_st...
net/socket_stream/socket_stream.h:115: net::URLRequestContext* context() const {
return context_.get(); }
Undo the changes in this file (already in the 'net' namespace).

http://codereview.chromium.org/6338002/diff/10001/net/socket_stream/socket_st...
File net/socket_stream/socket_stream_job.h (right):

http://codereview.chromium.org/6338002/diff/10001/net/socket_stream/socket_st...
net/socket_stream/socket_stream_job.h:45: net::URLRequestContext* context()
const {
Undo the changes to this file (already in the 'net' namespace)./

http://codereview.chromium.org/6338002/diff/10001/net/spdy/spdy_test_util.h
File net/spdy/spdy_test_util.h (right):

http://codereview.chromium.org/6338002/diff/10001/net/spdy/spdy_test_util.h#n...
net/spdy/spdy_test_util.h:400: class SpdyURLRequestContext : public
net::URLRequestContext {
Undo this change (already in the 'net' namespace).

http://codereview.chromium.org/6338002/diff/10001/net/websockets/websocket_jo...
File net/websockets/websocket_job_unittest.cc (right):

http://codereview.chromium.org/6338002/diff/10001/net/websockets/websocket_jo...
net/websockets/websocket_job_unittest.cc:180: class MockURLRequestContext :
public net::URLRequestContext {
Undo this change (already in the 'net' namespace).