Issue 6336014: Fix printing PDFs through right click on Mac and Linux. Looks like they both...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6336014: Fix printing PDFs through right click on Mac and Linux. Looks like they both... (Closed)

Created:
9 years, 11 months ago by jam

Modified:
9 years, 7 months ago

Reviewers:
Elliot Glaysher, evanm

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix printing PDFs through right click on Mac and Linux. Looks like they both give the menu closed notification before the notification about which item was clicked. BUG=70987 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72840

Patch Set 1 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -17 lines)			Patch
M	ui/base/models/simple_menu_model.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	ui/base/models/simple_menu_model.cc	View	3 chunks	+13 lines, -1 line	0 comments	Download
M	views/controls/menu/native_menu_win.cc	View	5 chunks	+2 lines, -16 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

evanm

This looks ok to me but I don't know menus too well -- Elliot can ...

9 years, 11 months ago (2011-01-27 18:13:04 UTC) #3

Elliot Glaysher

9 years, 11 months ago (2011-01-27 18:31:34 UTC) #4

On 2011/01/27 18:13:04, evanm wrote:
> This looks ok to me but I don't know menus too well -- Elliot can you take a
> look too?

The code LGTM. I can't put my finger on it, but this change makes me slightly
nervous but I can't verbalize why. OTOH, all the tests seem to pass.

Expand Messages | Collapse Messages