Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 6336012: Get rid of RenderViewHostDelegate::BrowserIntegration since it was unnecessar... (Closed)

Created:
9 years, 11 months ago by jam
Modified:
9 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Get rid of RenderViewHostDelegate::BrowserIntegration since it was unnecessary. RenderViewHost used to dispatch messages only to call that interface, and TabContents would do the work. Instead have TabContents dispatch the messages directly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72250

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -337 lines) Patch
M chrome/browser/renderer_host/render_view_host.h View 1 2 3 5 chunks +0 lines, -25 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.cc View 1 2 3 10 chunks +1 line, -129 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host_delegate.h View 1 2 3 4 chunks +8 lines, -75 lines 1 comment Download
M chrome/browser/renderer_host/render_view_host_delegate.cc View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/tab_contents/navigation_controller_unittest.cc View 1 2 3 5 chunks +3 lines, -12 lines 0 comments Download
M chrome/browser/tab_contents/render_view_host_manager_unittest.cc View 1 2 3 1 chunk +1 line, -6 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.h View 1 2 3 6 chunks +28 lines, -33 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 1 2 3 7 chunks +56 lines, -42 lines 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/worker_host/worker_process_host.cc View 1 2 3 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
9 years, 11 months ago (2011-01-21 21:15:56 UTC) #1
Avi (use Gerrit)
Uh, thanks for giving me more stuff to refactor? :) Code LGTM
9 years, 11 months ago (2011-01-21 21:23:19 UTC) #2
jam
I may be not understanding your comment, so if I'm wildly off, please ignore! This ...
9 years, 11 months ago (2011-01-21 21:26:23 UTC) #3
Evan Martin
9 years, 5 months ago (2011-07-20 20:09:46 UTC) #4
http://codereview.chromium.org/6336012/diff/33001/chrome/browser/renderer_hos...
File chrome/browser/renderer_host/render_view_host_delegate.h (right):

http://codereview.chromium.org/6336012/diff/33001/chrome/browser/renderer_hos...
chrome/browser/renderer_host/render_view_host_delegate.h:679: void
WorkerCrashed() {}
Missing 'virtual'.  Dun dun dunnnnnnn.  Review carefully!

Powered by Google App Engine
This is Rietveld 408576698