chrome/browser/tab_contents/render_view_host_manager_unittest.cc - Issue 6336012: Get rid of RenderViewHostDelegate::BrowserIntegration since it was unnecessar...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tab_contents/render_view_host_manager_unittest.cc

Issue 6336012: Get rid of RenderViewHostDelegate::BrowserIntegration since it was unnecessar... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/renderer_host/render_view_host_delegate.h ('K') | « chrome/browser/tab_contents/navigation_controller_unittest.cc ('k') | chrome/browser/tab_contents/tab_contents.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/tab_contents/render_view_host_manager_unittest.cc

===================================================================

--- chrome/browser/tab_contents/render_view_host_manager_unittest.cc (revision 72247)

+++ chrome/browser/tab_contents/render_view_host_manager_unittest.cc (working copy)

@@ -313,13 +313,8 @@

contents()->NavigateAndCommit(url2);

RenderViewHost* evil_rvh = contents()->render_view_host();

- // Casts the TabContents to a RenderViewHostDelegate::BrowserIntegration so we

- // can call GoToEntryAtOffset which is private.

- RenderViewHostDelegate::BrowserIntegration* rvh_delegate =

- static_cast<RenderViewHostDelegate::BrowserIntegration*>(contents());

// Now let's simulate the evil page calling history.back().

- rvh_delegate->GoToEntryAtOffset(-1);

+ contents()->OnGoToEntryAtOffset(-1);

// We should have a new pending RVH.

// Note that in this case, the navigation has not committed, so evil_rvh will

// not be deleted yet.