Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 6334152: Clean up RTL methods.... (Closed)

Created:
9 years, 10 months ago by Ben Goodger (Google)
Modified:
9 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, Erik does not do reviews, Aaron Boodman, pam+watch_chromium.org, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr., davemoore+watch_chromium.org
Visibility:
Public.

Description

Clean up RTL methods. No one used the non-RTL version of GetBounds(), so I renamed it GetMirroredBounds() and got rid of the enum. Same for GetX(), consolidated with MirroredX() into GetMirroredX(). GetPosition() already took into account mirroring, so renamed GetMirroredPosition() for symmetry. Renamed the other functions to be getters. De-inlined a few that were doing complex looking stuff. http://crbug.com/72040 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74087

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -166 lines) Patch
M chrome/browser/chromeos/input_method/candidate_window.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_util.cc View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/touch/tabs/touch_tab.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/bookmark_bar_view.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/browser_actions_container.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/constrained_window_win.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/download_item_view.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/app_panel_browser_frame_view.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view_layout.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 1 2 3 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/location_bar/keyword_hint_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/options/advanced_contents_view.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/status_bubble_views.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tabs/dragged_tab_controller.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tabs/dragged_tab_view.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 1 2 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/theme_install_bubble_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/wrench_menu.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M views/animation/bounds_animator.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M views/controls/button/menu_button.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M views/controls/button/text_button.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M views/controls/menu/menu_item_view.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M views/controls/menu/menu_item_view_gtk.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M views/controls/menu/menu_item_view_win.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M views/examples/widget_example.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M views/view.h View 1 2 5 chunks +15 lines, -56 lines 0 comments Download
M views/view.cc View 1 2 7 chunks +24 lines, -30 lines 0 comments Download
M views/view_text_utils.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M views/window/custom_frame_view.cc View 1 2 3 chunks +7 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
As usual, look at view.cc/h first.
9 years, 10 months ago (2011-02-08 01:05:31 UTC) #1
sky
9 years, 10 months ago (2011-02-08 01:15:45 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698