Cherry-pick a fix from r324 of the libjpeg-turbo stable branch that...

Cherry-pick a fix from r324 of the libjpeg-turbo stable branch that
adds further protections against invalid Huffman codes.

BUG=none
TEST=trybots

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73588

[Craig, 2011-02-02 15:21:29]

The description for this patch seems sufficiently alluring to warrant its
inclusion in our copy of libjpeg-turbo before we make libjpeg-turbo the default.
The patch is on both the stable and dev branches of libjpeg-turbo.

Please review.

(I will send to try servers later to make sure it doesn't break anything)

[Craig, 2011-02-02 16:11:36]

> (I will send to try servers later to make sure it doesn't break anything)

Try server stuff is here:

http://build.chromium.org/p/tryserver.chromium/builders/win/builds/13628
http://build.chromium.org/p/tryserver.chromium/builders/mac/builds/11237
http://build.chromium.org/p/tryserver.chromium/builders/linux/builds/10832

I used a combined diff that has both the change suggested here and a change to
build/common.gypi to enable libjpeg_turbo and uploaded the diff directly with
trychange.py

Depressingly the linux bot did not recompile the turbo file while the other bots
did which suggests some sort of bot or dependency problem. I will try sending it
again later as this trick has worked for me before for trying this sort of
change...

[Craig, 2011-02-02 16:26:53]

On 2011/02/02 16:11:36, Craig wrote:
> > (I will send to try servers later to make sure it doesn't break anything)
> 
> Try server stuff is here:
> 
> http://build.chromium.org/p/tryserver.chromium/builders/win/builds/13628
> http://build.chromium.org/p/tryserver.chromium/builders/mac/builds/11237
> http://build.chromium.org/p/tryserver.chromium/builders/linux/builds/10832
> 
> I used a combined diff that has both the change suggested here and a change to
> build/common.gypi to enable libjpeg_turbo and uploaded the diff directly with
> trychange.py
> 
> Depressingly the linux bot did not recompile the turbo file while the other
bots
> did which suggests some sort of bot or dependency problem. I will try sending
it
> again later as this trick has worked for me before for trying this sort of
> change...

I figured it out - it's my fault ... I didn't roll DEPS in the patch as well to
pick up the newer gyp file that uses libjpeg_turbo on linux rather than the
system libjpeg. Will resend with that change too.

[Craig, 2011-02-02 18:35:50]

New try server runs that actually exercise the changes:

http://build.chromium.org/p/tryserver.chromium/builders/linux/builds/10841
http://build.chromium.org/p/tryserver.chromium/builders/mac/builds/11245
http://build.chromium.org/p/tryserver.chromium/builders/win/builds/13636

(bits of redness there ... will stare at it later to see if it's a problem)

[Craig, 2011-02-02 18:42:21]

I found a better description of the problem the patch fixes:

http://sourceforge.net/tracker/?func=detail&aid=3023672&group_id=303195&atid=...

[Hironori Bono, 2011-02-03 02:04:07]

LGTM.
Thank you for your merge. It is definitely helpful to change the DEPS file so we
can pull the updated libjpeg-turbo after landing this change. :)

Regards,

Hironori Bono