Issue 6334: Simplify CodeGenerator hierarchy by not using a base class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6334: Simplify CodeGenerator hierarchy by not using a base class. (Closed)

Created:
12 years, 2 months ago by iposva

Modified:
9 years, 4 months ago

Reviewers:
Feng Qian, Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Simplify CodeGenerator hierarchy by not using a base class. There is nothing virtual about a CodeGenerator since we either generate code for one platform or for the other. Committed: http://code.google.com/p/v8/source/detail?r=480

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1059 lines, -1025 lines)			Patch
	src/codegen.h	View	1 2	3 chunks	+32 lines, -123 lines	0 comments	Download
M	src/codegen.cc	View		2 chunks	+94 lines, -0 lines	0 comments	Download
A	src/codegen-arm.h	View		1 chunk	+371 lines, -0 lines	0 comments	Download
M	src/codegen-arm.cc	View		67 chunks	+86 lines, -436 lines	0 comments	Download
A	src/codegen-ia32.h	View	1	1 chunk	+385 lines, -0 lines	0 comments	Download
M	src/codegen-ia32.cc	View	1	71 chunks	+86 lines, -465 lines	0 comments	Download
M	tools/v8.xcodeproj/project.pbxproj	View		3 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Feng Qian

http://codereview.chromium.org/6334/diff/5/210 File src/codegen.h (right): http://codereview.chromium.org/6334/diff/5/210#newcode43 Line 43: A documentation here describing the contract of codegen-<arch> ...

12 years, 2 months ago (2008-10-09 23:15:28 UTC) #2

After update comments, LGTM

Expand Messages | Collapse Messages