Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 6330011: Prepare to revert WebKit patch http://trac.webkit.org/changeset/68310 because of stability issues. (Closed)

Created:
9 years, 11 months ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Prepare to revert WebKit patch http://trac.webkit.org/changeset/68310 because of stability issues (race conditions detected by tsan, possibly leading to crashes). Revert "Update sqlite's README.chromium with a note to keep webkit side" (http://crrev.com/62151). Revert "Remove our local modifications to sqlite's os_unix.c now that" (http://crrev.com/60761). BUG=70589, 22208 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72673

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -22 lines) Patch
M third_party/sqlite/README.chromium View 2 chunks +15 lines, -5 lines 0 comments Download
M third_party/sqlite/src/src/os_unix.c View 5 chunks +75 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Paweł Hajdan Jr.
Please review, it's a one step towards fixing an important stability issue.
9 years, 11 months ago (2011-01-26 09:43:01 UTC) #1
evanm
Can you map the commit hashes to svn revision numbers before committing and update the ...
9 years, 11 months ago (2011-01-26 17:14:11 UTC) #2
Scott Hess - ex-Googler
Also LGTM. I think you should just drop the "This reverts commit <hash>" lines, they ...
9 years, 11 months ago (2011-01-26 19:08:32 UTC) #3
michaeln
9 years, 11 months ago (2011-01-26 21:39:09 UTC) #4
> Super weird that we use sqlite dbs from multiple threads
> simultaneously (?!)

Different handles on different threads.

Powered by Google App Engine
This is Rietveld 408576698