Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/sqlite/README.chromium

Issue 6330011: Prepare to revert WebKit patch http://trac.webkit.org/changeset/68310 because of stability issues. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | third_party/sqlite/src/src/os_unix.c » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 Name: SQLite 1 Name: SQLite
2 License File: src/LICENSE 2 License File: src/LICENSE
3 URL: http://sqlite.org/ 3 URL: http://sqlite.org/
4 4
5 Instructions for importing a new release of SQLite from sqlite.org. 5 Instructions for importing a new release of SQLite from sqlite.org.
6 6
7 Note: our current base version is 3.6.18. 7 Note: our current base version is 3.6.18.
8 8
9 First, you need to be on Linux. 9 First, you need to be on Linux.
10 10
(...skipping 24 matching lines...) Expand all
35 35
36 # Resolve any conflicts. Figure out if we've got everything we should 36 # Resolve any conflicts. Figure out if we've got everything we should
37 # have (see below), or if we can omit any changes we no longer need. 37 # have (see below), or if we can omit any changes we no longer need.
38 38
39 # Change to the sqlite directory: 39 # Change to the sqlite directory:
40 cd sqlite 40 cd sqlite
41 41
42 # Run the google_generate_preprocessed.sh script: 42 # Run the google_generate_preprocessed.sh script:
43 ./google_generate_preprocessed.sh 43 ./google_generate_preprocessed.sh
44 44
45 # If there are any updates to os_unix.c, remember to keep
46 # WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp in sync.
47 # This means preparing a separate patch for WebKit.
48 # If you have questions about this part, ask phajdan.jr and dumi.
49
50 # Find a sucker. Send review. 45 # Find a sucker. Send review.
51 # TODO(shess) Describe an appropriate comment style. Seems like it 46 # TODO(shess) Describe an appropriate comment style. Seems like it
52 # should at least include the SQLite version number. 47 # should at least include the SQLite version number.
53 48
54 -------------------------------------------- 49 --------------------------------------------
55 50
56 For reference, all of our local patches are also kept as .patch files in the 51 For reference, all of our local patches are also kept as .patch files in the
57 sqlite directory. Here is a list of the patches, in the order they should be 52 sqlite directory. Here is a list of the patches, in the order they should be
58 applied to a vanilla SQLite (of the version we currently have) to get, in 53 applied to a vanilla SQLite (of the version we currently have) to get, in
59 principle, exactly what is checked in: 54 principle, exactly what is checked in:
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 - fts2_icu.c and fts3_icu.c have a critical bug. U8_NEXT is used over 148 - fts2_icu.c and fts3_icu.c have a critical bug. U8_NEXT is used over
154 a UTF-16 string. It's rep$ by U16_NEXT (jungshik) 149 a UTF-16 string. It's rep$ by U16_NEXT (jungshik)
155 - Added a new function sqlite3Preload we use to prime the database cache. It 150 - Added a new function sqlite3Preload we use to prime the database cache. It
156 allows much faster performance by reading the file in one contiguous 151 allows much faster performance by reading the file in one contiguous
157 operation rather than bringing it in organically, which involves a lot of 152 operation rather than bringing it in organically, which involves a lot of
158 seeking. This change also required sqlite3PcacheGetCachesize to be compiled 153 seeking. This change also required sqlite3PcacheGetCachesize to be compiled
159 even outside SQLITE_TEST. 154 even outside SQLITE_TEST.
160 - Added a new function chromium_sqlite3_initialize_win_sqlite3_file() 155 - Added a new function chromium_sqlite3_initialize_win_sqlite3_file()
161 at the end of os_win.c. It allows the Windows-specific Chromium VFS 156 at the end of os_win.c. It allows the Windows-specific Chromium VFS
162 to reuse most of the win32 SQLite VFS. 157 to reuse most of the win32 SQLite VFS.
158 - Added a new function
159 chromium_sqlite3_initialize_unix_sqlite3_file() and made
160 fillInUnixFile() non-static in os_unix.c. It allows the
161 Linux-specific Chromium VFS to reuse most of the unix SQLite VFS.
162 - Exposed three functions that deal with unused file descriptors in
163 os_unix.c, to allow Chromium's Posix VFS implementation in
164 WebKit/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp
165 to correctly implement the "unused file descriptors" logic in the
166 xDlOpen() method. The new functions are
167 chromium_sqlite3_get_reusable_file_handle(),
168 chromium_sqlite3_update_reusable_file_handle() and
169 chromium_sqlite3_destroy_reusable_file_handle(). Also, added the
170 chromium_sqlite3_fill_in_unix_sqlite3_file() function that calls
171 fillInUnixFile(), which will be made static again as soon as a
172 WebKit patch using the new function lands.
OLDNEW
« no previous file with comments | « no previous file | third_party/sqlite/src/src/os_unix.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698