Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: chrome/browser/extensions/extension_host.cc

Issue 6330007: Don't use GetAsTabContents. Send notifications from TabContentsView instead. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_host.h ('k') | chrome/browser/notifications/balloon_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_host.cc
diff --git a/chrome/browser/extensions/extension_host.cc b/chrome/browser/extensions/extension_host.cc
index 09fe9e61fb54150aecd22e81eb227d8a4eab83bb..b85497194d068bba92b55c6691476f6d0860e43a 100644
--- a/chrome/browser/extensions/extension_host.cc
+++ b/chrome/browser/extensions/extension_host.cc
@@ -533,8 +533,7 @@ RenderViewHostDelegate::View* ExtensionHost::GetViewDelegate() {
void ExtensionHost::CreateNewWindow(
int route_id,
- WindowContainerType window_container_type,
- const string16& frame_name) {
+ const ViewHostMsg_CreateWindow_Params& params) {
// TODO(aa): Use the browser's profile if the extension is split mode
// incognito.
TabContents* new_contents = delegate_view_helper_.CreateNewWindow(
@@ -544,8 +543,8 @@ void ExtensionHost::CreateNewWindow(
DOMUIFactory::GetDOMUIType(render_view_host()->process()->profile(),
url_),
this,
- window_container_type,
- frame_name);
+ params.window_container_type,
+ params.frame_name);
TabContents* associated_contents = associated_tab_contents();
if (associated_contents && associated_contents->delegate())
« no previous file with comments | « chrome/browser/extensions/extension_host.h ('k') | chrome/browser/notifications/balloon_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698