Issue 6330006: Disable BrowserTest RenderViewTest.OnNavStateChanged

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6330006: Disable BrowserTest RenderViewTest.OnNavStateChanged (Closed)

Created:
9 years, 11 months ago by John Knottenbelt

Modified:
9 years, 7 months ago

Reviewers:
bulach

CC:
chromium-reviews, Paweł Hajdan Jr., darin-cc_chromium.org, brettw-cc_chromium.org, jorlow, brettw

Base URL:
svn://svn.chromium.org/chrome/trunk/src/chrome/renderer

Visibility:
Public.

Description

Disable BrowserTest RenderViewTest.OnNavStateChanged WebKit change http://trac.webkit.org/changeset/76291 may have affected this test. TBR=brettw BUG=70408 TEST=BrowserTest: RenderViewTest.OnNavStateChanged Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72142

Patch Set 1 #

Patch Set 2 : Disable BrowserTest RenderViewTest.OnNavStateChanged #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/renderer/render_view_browsertest.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

John Knottenbelt

Hi Brett, Marcus and I are looking at this bug, but if you have any ...

9 years, 11 months ago (2011-01-21 16:27:06 UTC) #3

brettw

9 years, 11 months ago (2011-01-21 21:53:10 UTC) #4

This is used when a form element changes state so we know to tell the
browser to save the form state for session restore. There should be
callbacks from the form elements to our API (sadly, I don't remember
how this works at all). We coalesce them so we don't spam the browser
with lots of update messages for each keystroke.

Sorry I don't remember more specifics about how this works. It's
possible something in the callback chain has been inadvertently
broken. I hope this helps a little.

Brett

On Fri, Jan 21, 2011 at 8:27 AM,  <jknotten@chromium.org> wrote:
> Hi Brett,
>
> Marcus and I are looking at this bug, but if you have any hints or
> suggestions
> on what might be the fix, they would be much appreciated!
>
> Thanks
>
> John
>
> http://codereview.chromium.org/6330006/
>

Expand Messages | Collapse Messages