Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: chrome/renderer/render_view_browsertest.cc

Issue 6330006: Disable BrowserTest RenderViewTest.OnNavStateChanged (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/chrome/renderer
Patch Set: Disable BrowserTest RenderViewTest.OnNavStateChanged Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/basictypes.h" 5 #include "base/basictypes.h"
6 6
7 #include "base/file_util.h" 7 #include "base/file_util.h"
8 #include "base/shared_memory.h" 8 #include "base/shared_memory.h"
9 #include "base/string_util.h" 9 #include "base/string_util.h"
10 #include "base/utf_string_conversions.h" 10 #include "base/utf_string_conversions.h"
(...skipping 28 matching lines...) Expand all
39 using webkit_glue::FormData; 39 using webkit_glue::FormData;
40 using webkit_glue::FormField; 40 using webkit_glue::FormField;
41 41
42 namespace { 42 namespace {
43 43
44 // TODO(isherman): Pull this as a named constant from WebKit 44 // TODO(isherman): Pull this as a named constant from WebKit
45 const int kDefaultMaxLength = 0x80000; 45 const int kDefaultMaxLength = 0x80000;
46 46
47 } // namespace 47 } // namespace
48 48
49 // TODO(jknotten). Fix http://code.google.com/p/chromium/issues/detail?id=70408
49 // Test that we get form state change notifications when input fields change. 50 // Test that we get form state change notifications when input fields change.
50 TEST_F(RenderViewTest, OnNavStateChanged) { 51 TEST_F(RenderViewTest, DISABLED_OnNavStateChanged) {
51 // Don't want any delay for form state sync changes. This will still post a 52 // Don't want any delay for form state sync changes. This will still post a
52 // message so updates will get coalesced, but as soon as we spin the message 53 // message so updates will get coalesced, but as soon as we spin the message
53 // loop, it will generate an update. 54 // loop, it will generate an update.
54 view_->set_send_content_state_immediately(true); 55 view_->set_send_content_state_immediately(true);
55 56
56 LoadHTML("<input type=\"text\" id=\"elt_text\"></input>"); 57 LoadHTML("<input type=\"text\" id=\"elt_text\"></input>");
57 58
58 // We should NOT have gotten a form state change notification yet. 59 // We should NOT have gotten a form state change notification yet.
59 EXPECT_FALSE(render_thread_.sink().GetFirstMessageMatching( 60 EXPECT_FALSE(render_thread_.sink().GetFirstMessageMatching(
60 ViewHostMsg_UpdateState::ID)); 61 ViewHostMsg_UpdateState::ID));
(...skipping 1168 matching lines...) Expand 10 before | Expand all | Expand 10 after
1229 LoadHTML("<html><head><meta http-equiv=\"content-language\" " 1230 LoadHTML("<html><head><meta http-equiv=\"content-language\" "
1230 "content=\" fr , es,en \">" 1231 "content=\" fr , es,en \">"
1231 "</head><body>A random page with random content.</body></html>"); 1232 "</head><body>A random page with random content.</body></html>");
1232 ProcessPendingMessages(); 1233 ProcessPendingMessages();
1233 message = render_thread_.sink().GetUniqueMessageMatching( 1234 message = render_thread_.sink().GetUniqueMessageMatching(
1234 ViewHostMsg_PageContents::ID); 1235 ViewHostMsg_PageContents::ID);
1235 ASSERT_NE(static_cast<IPC::Message*>(NULL), message); 1236 ASSERT_NE(static_cast<IPC::Message*>(NULL), message);
1236 ViewHostMsg_PageContents::Read(message, &params); 1237 ViewHostMsg_PageContents::Read(message, &params);
1237 EXPECT_EQ("fr", params.d); 1238 EXPECT_EQ("fr", params.d);
1238 } 1239 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698