Use FilePath::Extension instead of the deprecated file_util::GetFileExtensionFromPath.

Use FilePath::Extension instead of the deprecated file_util::GetFileExtensionFromPath.

BUG=24672
TEST=trybots

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72732

[tfarina, 2011-01-26 20:03:22]

Hi Evan, could you review this to me?

[Evan Martin, 2011-01-26 20:10:21]

It's funny to see the exact same pattern done in two different ways :)

http://codereview.chromium.org/6326014/diff/1/chrome/browser/printing/printin...
File chrome/browser/printing/printing_layout_uitest.cc (right):

http://codereview.chromium.org/6326014/diff/1/chrome/browser/printing/printin...
chrome/browser/printing/printing_layout_uitest.cc:147: if
(!_wcsicmp(ext.c_str(), L".emf")) {
I suggesting these to use the pattern found in the other file (converting to
UTF8 and dropping the "L"

[tfarina, 2011-01-26 20:21:25]

http://codereview.chromium.org/6326014/diff/1/chrome/browser/printing/printin...
File chrome/browser/printing/printing_layout_uitest.cc (right):

http://codereview.chromium.org/6326014/diff/1/chrome/browser/printing/printin...
chrome/browser/printing/printing_layout_uitest.cc:147: if
(!_wcsicmp(ext.c_str(), L".emf")) {
On 2011/01/26 20:10:21, Evan Martin wrote:
> I suggesting these to use the pattern found in the other file (converting to
> UTF8 and dropping the "L"

Done.

Evan, a question:
The description for wcsicmp says:
"compare two wide-character strings, by converting them into lower-case".

Should I bother with this, and convert ext to lower case too (using
base::StringToLowerASCII)?

[evanm, 2011-01-26 20:23:10]

On 2011/01/26 20:21:25, tfarina wrote:
> Should I bother with this, and convert ext to lower case too (using
> base::StringToLowerASCII)?

The way mini_installer does it is using base::strcasecmp, which is a
case-insensitive compare.

[tfarina, 2011-01-26 20:30:12]

On 2011/01/26 20:23:10, evanm wrote:
> On 2011/01/26 20:21:25, tfarina wrote:
> > Should I bother with this, and convert ext to lower case too (using
> > base::StringToLowerASCII)?
> 
> The way mini_installer does it is using base::strcasecmp, which is a
> case-insensitive compare.

So I guess this is done. Could you take another look?

[Evan Martin, 2011-01-26 20:30:59]

perfect, thanks!

LGTM