Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(984)

Unified Diff: chrome/test/mini_installer_test/mini_installer_test_util.cc

Issue 6326014: Use FilePath::Extension instead of the deprecated file_util::GetFileExtensionFromPath. (Closed)
Patch Set: evan review Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/printing/printing_layout_uitest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/mini_installer_test/mini_installer_test_util.cc
diff --git a/chrome/test/mini_installer_test/mini_installer_test_util.cc b/chrome/test/mini_installer_test/mini_installer_test_util.cc
index 7c0dddd7a24049b933797001a4607a8ba869ca55..2df756f7be2e6c518a395cf34974aa97b7b39ccb 100644
--- a/chrome/test/mini_installer_test/mini_installer_test_util.cc
+++ b/chrome/test/mini_installer_test/mini_installer_test_util.cc
@@ -1,9 +1,10 @@
-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/test/mini_installer_test/mini_installer_test_util.h"
+#include "base/file_path.h"
#include "base/file_util.h"
#include "base/path_service.h"
#include "base/process_util.h"
@@ -145,8 +146,8 @@ bool MiniInstallerTestUtil::GetLatestFile(const wchar_t* file_name,
std::wstring search_path = find_file_data.cFileName;
size_t position_found = search_path.find(pattern);
if (position_found != -1) {
- std::wstring extension = file_util::GetFileExtensionFromPath(file_name);
- if ((base::strcasecmp(WideToUTF8(extension).c_str(), "exe")) == 0) {
+ std::wstring extension = FilePath(file_name).Extension();
+ if ((base::strcasecmp(WideToUTF8(extension).c_str(), ".exe")) == 0) {
file_details->push_back(FileInfo(find_file_data.cFileName, 0));
return_val = true;
break;
« no previous file with comments | « chrome/browser/printing/printing_layout_uitest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698