Issue 6324014: Fixed grave bug in Plugin Loading code that lead to a crash with some plugins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6324014: Fixed grave bug in Plugin Loading code that lead to a crash with some plugins. (Closed)

Created:
9 years, 11 months ago by pastarmovj

Modified:
9 years, 7 months ago

Reviewers:
jam

CC:
chromium-reviews, darin-cc_chromium.org, davemoore+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fixed grave bug in Plugin Loading code that lead to a crash with some plugins. When plugins are not properly written they don't supply any identificatrion info through their api which used to kill the plugin loading code. BUG=70775 TEST=test_shell_tests-PluginListTest.BadPluginDescription Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72557

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -8 lines)			Patch
M	chrome/browser/chromeos/gview_request_interceptor_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/plugins/npapi/plugin_list.cc	View	2 chunks	+7 lines, -7 lines	0 comments	Download
M	webkit/plugins/npapi/plugin_list_unittest.cc	View	1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages