Fixed grave bug in Plugin Loading code that lead to a crash with some plugins.

webkit/plugins/npapi/plugin_list_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/plugins/npapi/plugin_list.h"
 
 #include "base/utf_string_conversions.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace webkit {
@@ skipping 164 matching lines @@
   EXPECT_EQ(group_3043, group_3045);
   group_3043->version_ranges_.push_back(VersionRange(version_range[0]));
   group_3043->version_ranges_.push_back(VersionRange(version_range[1]));
   EXPECT_EQ(plugin_3043.desc, group_3043->description());
   EXPECT_TRUE(group_3043->IsVulnerable());
   group_3043->DisableOutdatedPlugins();
   EXPECT_EQ(plugin_3045.desc, group_3043->description());
   EXPECT_FALSE(group_3043->IsVulnerable());
 }
 
+TEST_F(PluginListTest, BadPluginDescription) {
+  WebPluginInfo plugin_3043(ASCIIToUTF16(""),
+                            FilePath(FILE_PATH_LITERAL("/myplugin.3.0.43")),
+                            ASCIIToUTF16(""),
+                            ASCIIToUTF16(""));
+  // Simulate loading of the plugins.
+  plugin_list_.plugins_to_load_.clear();
+  plugin_list_.plugins_to_load_.push_back(plugin_3043);
+  // Now we should have them in the state we specified above.
+  std::vector<WebPluginInfo> plugins;
+  plugin_list_.GetPlugins(true, &plugins);
+  ASSERT_TRUE(Contains(plugins, plugin_3043, true));
+}
+
 TEST_F(PluginListTest, DisableAndEnableBeforeLoad) {
   WebPluginInfo plugin_3043(ASCIIToUTF16("MyPlugin"),
                             FilePath(FILE_PATH_LITERAL("/myplugin.3.0.43")),
                             ASCIIToUTF16("3.0.43"),
                             ASCIIToUTF16("MyPlugin version 3.0.43"));
   WebPluginInfo plugin_3045(ASCIIToUTF16("MyPlugin"),
                             FilePath(FILE_PATH_LITERAL("/myplugin.3.0.45")),
                             ASCIIToUTF16("3.0.45"),
                             ASCIIToUTF16("MyPlugin version 3.0.45"));
   // Disable the first one and disable and then enable the second one.
   EXPECT_TRUE(plugin_list_.DisablePlugin(plugin_3043.path));
   EXPECT_TRUE(plugin_list_.DisablePlugin(plugin_3045.path));
   EXPECT_TRUE(plugin_list_.EnablePlugin(plugin_3045.path));
   // Simulate loading of the plugins.
   plugin_list_.plugins_to_load_.clear();
   plugin_list_.plugins_to_load_.push_back(plugin_3043);
   plugin_list_.plugins_to_load_.push_back(plugin_3045);
   // Now we should have them in the state we specified above.
   std::vector<WebPluginInfo> plugins;
   plugin_list_.GetPlugins(true, &plugins);
   plugin_3043.enabled = WebPluginInfo::USER_DISABLED_POLICY_UNMANAGED;
   ASSERT_TRUE(Contains(plugins, plugin_3043, true));
   ASSERT_TRUE(Contains(plugins, plugin_3045, true));
 }
 
 }  // namespace npapi
 }  // namespace webkit