Issue 6320005: Fix a regression that was introduced in http://codereview.chromium.org/6010004/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6320005: Fix a regression that was introduced in http://codereview.chromium.org/6010004/ (Closed)

Created:
9 years, 11 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
brettw, DaveMoore, sky

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix a regression that was introduced in http://codereview.chromium.org/6010004/ BUG=none TEST=No DCHECK when triggering tabpose Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71666

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/tab_contents/thumbnail_generator.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

9 years, 11 months ago (2011-01-18 06:13:28 UTC) #2

Wow, insidious!  LGTM

On Mon, Jan 17, 2011 at 4:44 PM,  <thakis@chromium.org> wrote:
> Reviewers: brettw, sky, davemoore,
>
> Description:
> Fix a regression that was introduced in
> http://codereview.chromium.org/6010004/
>
> BUG=none
> TEST=No DCHECK when triggering tabpose
>
> Please review this at http://codereview.chromium.org/6320005/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/browser/tab_contents/thumbnail_generator.cc
>
>
> Index: chrome/browser/tab_contents/thumbnail_generator.cc
> diff --git a/chrome/browser/tab_contents/thumbnail_generator.cc
> b/chrome/browser/tab_contents/thumbnail_generator.cc
> index
>
a26bca08c39766143ca231983fa211eaaa5bd4ae..c37071918801f96ded0fa3312f8f7e3d5b66f200
> 100644
> --- a/chrome/browser/tab_contents/thumbnail_generator.cc
> +++ b/chrome/browser/tab_contents/thumbnail_generator.cc
> @@ -180,7 +180,7 @@ void
> ThumbnailGenerator::MonitorRenderer(RenderWidgetHost* renderer,
>         this,
>         NotificationType::RENDER_WIDGET_HOST_WILL_DESTROY_BACKING_STORE,
>         renderer_source);
> -  if (monitor |= currently_monitored) {
> +  if (monitor != currently_monitored) {
>     if (monitor) {
>       registrar_.Add(
>           this,
>
>
>

Expand Messages | Collapse Messages