Issue 6315002: Some wstring -> string16 conversion in src/app.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6315002: Some wstring -> string16 conversion in src/app. (Closed)

Created:
9 years, 11 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin, gregoryd

CC:
chromium-reviews, jshin+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/app

Visibility:
Public.

Description

Some wstring -> string16 conversion in src/app. It looks like l10n_util_dummy.cc isn't needed anymore: The function in the file doesn't match any functions in l10n_util.h. Convert BidiLineIterator to use string16. I don't see any unittests for this file. :( BUG=23581 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71667

Patch Set 1 #

Patch Set 2 : rebase #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -35 lines)			Patch
M	app/app_base.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	app/bidi_line_iterator.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	app/bidi_line_iterator.cc	View	2 chunks	+2 lines, -7 lines	0 comments	Download
D	app/l10n_util_dummy.cc	View	1 chunk	+0 lines, -22 lines	0 comments	Download
M	app/resource_bundle_dummy.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	app/resource_bundle_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	views/view_text_utils.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tony

gregoryd: Can you verify that it's safe for me to remove l10n_util_dummy.cc? I'm not sure ...

9 years, 11 months ago (2011-01-14 17:38:43 UTC) #2

Evan Martin

Lgtm brevity due to phone On Jan 14, 2011 9:38 AM, <tony@chromium.org> wrote: > gregoryd: ...

9 years, 11 months ago (2011-01-14 18:27:03 UTC) #3

gregoryd

9 years, 11 months ago (2011-01-16 07:27:48 UTC) #4

The windows try bots do build the 64-bit part, since the 64-bit nacl binary is
part of the Chrome for Windows package.

LGTM.

On 2011/01/14 17:38:43, tony wrote:
> gregoryd: Can you verify that it's safe for me to remove l10n_util_dummy.cc? 
> I'm not sure if the try bot tests the 64-bit nacl build.

Expand Messages | Collapse Messages