Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: app/bidi_line_iterator.cc

Issue 6315002: Some wstring -> string16 conversion in src/app. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/app
Patch Set: rebase Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « app/bidi_line_iterator.h ('k') | app/l10n_util_dummy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: app/bidi_line_iterator.cc
diff --git a/app/bidi_line_iterator.cc b/app/bidi_line_iterator.cc
index 2002c0d37bd64edcaf72eb5bda3fa1dd4760584c..3312ef0685d880b8ba721b546f577cb2065c82dd 100644
--- a/app/bidi_line_iterator.cc
+++ b/app/bidi_line_iterator.cc
@@ -15,7 +15,7 @@ BiDiLineIterator::~BiDiLineIterator() {
}
}
-UBool BiDiLineIterator::Open(const std::wstring& text,
+UBool BiDiLineIterator::Open(const string16& text,
bool right_to_left,
bool url) {
DCHECK(bidi_ == NULL);
@@ -25,12 +25,7 @@ UBool BiDiLineIterator::Open(const std::wstring& text,
return false;
if (right_to_left && url)
ubidi_setReorderingMode(bidi_, UBIDI_REORDER_RUNS_ONLY);
-#if defined(WCHAR_T_IS_UTF32)
- const string16 text_utf16 = WideToUTF16(text);
-#else
- const std::wstring &text_utf16 = text;
-#endif // U_SIZEOF_WCHAR_T != 4
- ubidi_setPara(bidi_, text_utf16.data(), static_cast<int>(text_utf16.length()),
+ ubidi_setPara(bidi_, text.data(), static_cast<int>(text.length()),
right_to_left ? UBIDI_DEFAULT_RTL : UBIDI_DEFAULT_LTR,
NULL, &error);
return U_SUCCESS(error);
« no previous file with comments | « app/bidi_line_iterator.h ('k') | app/l10n_util_dummy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698