Issue 6314012: Make uneditable when readonly

Issue 6314012: Make uneditable when readonly (Closed)

Created:
9 years, 11 months ago by oshima

Modified:
9 years, 6 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, Paweł Hajdan Jr., James Su, Peter Kasting

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Make uneditable when readonly. This change makes the textfield uneditable. The text can still be updated via API (which is necessary to show URL in popup). BUG=none TEST=uadded new ReadOnlyTest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72022

Patch Set 1 #

Patch Set 2 : " #

Total comments: 4

Patch Set 3 : " #

Patch Set 4 : "revert direction change." #

Patch Set 5 : update comment #

Patch Set 6 : " #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+105 lines, -20 lines)			Patch
M	views/controls/textfield/native_textfield_views.cc	View		8 chunks	+19 lines, -9 lines	0 comments	Download
M	views/controls/textfield/native_textfield_views_unittest.cc	View	1 2 3 4 5	4 chunks	+68 lines, -2 lines	0 comments	Download
M	views/controls/textfield/textfield.h	View	1 2 3 4	1 chunk	+5 lines, -3 lines	0 comments	Download
M	views/controls/textfield/textfield_views_model.cc	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download
M	views/controls/textfield/textfield_views_model_unittest.cc	View	1 2 3 4 5	4 chunks	+10 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

LGTM http://codereview.chromium.org/6314012/diff/2001/views/controls/textfield/native_textfield_views_unittest.cc File views/controls/textfield/native_textfield_views_unittest.cc (right): http://codereview.chromium.org/6314012/diff/2001/views/controls/textfield/native_textfield_views_unittest.cc#newcode460 views/controls/textfield/native_textfield_views_unittest.cc:460: views::ViewsDelegate::views_delegate->GetClipboard() -> on end of this line http://codereview.chromium.org/6314012/diff/2001/views/controls/textfield/native_textfield_views_unittest.cc#newcode465 ...

9 years, 11 months ago (2011-01-20 18:31:24 UTC) #2

oshima

http://codereview.chromium.org/6314012/diff/2001/views/controls/textfield/native_textfield_views_unittest.cc File views/controls/textfield/native_textfield_views_unittest.cc (right): http://codereview.chromium.org/6314012/diff/2001/views/controls/textfield/native_textfield_views_unittest.cc#newcode460 views/controls/textfield/native_textfield_views_unittest.cc:460: views::ViewsDelegate::views_delegate->GetClipboard() On 2011/01/20 18:31:24, Ben Goodger wrote: > -> ...

9 years, 11 months ago (2011-01-20 21:13:46 UTC) #3

oshima

Ben, I reverted the selection direction change (see earlier emaiL) and ploaded new patch. I ...

9 years, 11 months ago (2011-01-20 21:15:36 UTC) #4

OK

Expand Messages | Collapse Messages