views/controls/textfield/textfield_views_model.cc - Issue 6314012: Make uneditable when readonly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: views/controls/textfield/textfield_views_model.cc

Issue 6314012: Make uneditable when readonly (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: " Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: views/controls/textfield/textfield_views_model.cc

diff --git a/views/controls/textfield/textfield_views_model.cc b/views/controls/textfield/textfield_views_model.cc

index 462c97088410f8cff7ee296325c3b4e0a4e1842b..585840d8dbf38da63a5ab9364794e2935a1948a8 100644

--- a/views/controls/textfield/textfield_views_model.cc

+++ b/views/controls/textfield/textfield_views_model.cc

@@ -230,8 +230,9 @@ void TextfieldViewsModel::SelectRange(const TextRange& range) {

}

void TextfieldViewsModel::SelectAll() {

- cursor_pos_ = 0;

- selection_begin_ = text_.length();

+ // SelectAll selects towards the end.

+ cursor_pos_ = text_.length();

+ selection_begin_ = 0;

}

void TextfieldViewsModel::ClearSelection() {