Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1218)

Issue 63113: Convert Windows Sleep to PlatformThread::Sleep... (Closed)

Created:
11 years, 8 months ago by Mohamed Mansour (USE mhm)
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Convert Windows Sleep to PlatformThread::Sleep First stage to make tests/others cross-platform. BUG=None TEST=Ran tests successfully (windows)

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -75 lines) Patch
M chrome/browser/browser_uitest.cc View 1 8 chunks +13 lines, -9 lines 0 comments Download
M chrome/browser/crash_recovery_uitest.cc View 1 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/download/save_page_uitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/errorpage_uitest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/printing/printing_layout_uitest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc View 1 6 chunks +10 lines, -6 lines 0 comments Download
M chrome/browser/tab_contents/view_source_uitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/unload_uitest.cc View 5 chunks +9 lines, -13 lines 0 comments Download
M chrome/browser/views/constrained_window_impl_interactive_uitest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/ipc_tests.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/logging_chrome_uitest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/automated_ui_tests/automated_ui_tests.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/automation/autocomplete_edit_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/automation/automation_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/automation/automation_proxy_uitest.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M chrome/test/memory_test/memory_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/reliability/page_load_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/ui/ui_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Mohamed Mansour (USE mhm)
11 years, 8 months ago (2009-04-08 03:37:23 UTC) #1
Evan Martin
Does it compile on Windows? http://codereview.chromium.org/63113/diff/1/19 File chrome/browser/browser_uitest.cc (right): http://codereview.chromium.org/63113/diff/1/19#newcode68 Line 68: PlatformThread::Sleep(sleep_timeout_ms()); // The ...
11 years, 8 months ago (2009-04-08 17:18:46 UTC) #2
Mohamed Mansour (USE mhm)
> Does it compile on Windows? I just compiled the solution right now, it does ...
11 years, 8 months ago (2009-04-08 21:59:25 UTC) #3
Mohamed Mansour (USE mhm)
Do you need this anymore? or I can discard?
11 years, 8 months ago (2009-04-27 23:29:57 UTC) #4
Evan Martin
I was gonna apply it, but I'd rather fix the files as we come to ...
11 years, 8 months ago (2009-04-27 23:35:47 UTC) #5
Evan Martin
r14688, thanks for the patch
11 years, 8 months ago (2009-04-28 00:11:49 UTC) #6
Mohamed Mansour (USE mhm)
On 2009/04/28 00:11:49, Evan Martin wrote: > r14688, thanks for the patch Actually, it wasn't ...
11 years, 8 months ago (2009-04-28 01:54:35 UTC) #7
Evan Martin
11 years, 8 months ago (2009-04-28 01:59:42 UTC) #8
On 2009/04/28 01:54:35, Mohamed Mansour wrote:
> Actually, it wasn't a sed script, I did them manually, lame but I don't trust
my
> scripts well :/

BTW, I only committed the non-conflicting bits.  I figured some of the files had
been fixed already, and that it'd be better to commit some of it then do another
review-repost cycle and have the parts that work rot further.  So if you sync
and there are still changes you have, please reopen this review.

Powered by Google App Engine
This is Rietveld 408576698