Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: chrome/browser/errorpage_uitest.cc

Issue 63113: Convert Windows Sleep to PlatformThread::Sleep... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/string_util.h" 5 #include "base/string_util.h"
6 #include "chrome/test/ui/ui_test.h" 6 #include "chrome/test/ui/ui_test.h"
7 #include "chrome/browser/automation/url_request_failed_dns_job.h" 7 #include "chrome/browser/automation/url_request_failed_dns_job.h"
8 #include "net/url_request/url_request_unittest.h" 8 #include "net/url_request/url_request_unittest.h"
9 9
10 class ErrorPageTest : public UITest { 10 class ErrorPageTest : public UITest {
11 }; 11 };
12 12
13 TEST_F(ErrorPageTest, DNSError) { 13 TEST_F(ErrorPageTest, DNSError) {
14 GURL test_url(URLRequestFailedDnsJob::kTestUrl); 14 GURL test_url(URLRequestFailedDnsJob::kTestUrl);
15 std::wstring test_host = UTF8ToWide(test_url.host()); 15 std::wstring test_host = UTF8ToWide(test_url.host());
16 NavigateToURL(test_url); 16 NavigateToURL(test_url);
17 17
18 // Verify that the url is in the title. Since it's set via Javascript, we 18 // Verify that the url is in the title. Since it's set via Javascript, we
19 // need to give it a chance to run. 19 // need to give it a chance to run.
20 int i; 20 int i;
21 std::wstring title; 21 std::wstring title;
22 for (i = 0; i < 10; ++i) { 22 for (i = 0; i < 10; ++i) {
23 Sleep(sleep_timeout_ms()); 23 PlatformThread::Sleep(sleep_timeout_ms());
24 title = GetActiveTabTitle(); 24 title = GetActiveTabTitle();
25 if (title.find(test_host) != std::wstring::npos) { 25 if (title.find(test_host) != std::wstring::npos) {
26 // Success, bail out. 26 // Success, bail out.
27 break; 27 break;
28 } 28 }
29 } 29 }
30 30
31 if (i == 10) { 31 if (i == 10) {
32 FAIL() << "failed to get error page title; got " << title; 32 FAIL() << "failed to get error page title; got " << title;
33 } 33 }
34 }; 34 };
35 35
36 TEST_F(ErrorPageTest, IFrame404) { 36 TEST_F(ErrorPageTest, IFrame404) {
37 // iframes that have 404 pages should not trigger an alternate error page. 37 // iframes that have 404 pages should not trigger an alternate error page.
38 // In this test, the iframe sets the title of the parent page to "SUCCESS" 38 // In this test, the iframe sets the title of the parent page to "SUCCESS"
39 // when the iframe loads. If the iframe fails to load (because an alternate 39 // when the iframe loads. If the iframe fails to load (because an alternate
40 // error page loads instead), then the title will remain as "FAIL". 40 // error page loads instead), then the title will remain as "FAIL".
41 scoped_refptr<HTTPTestServer> server = 41 scoped_refptr<HTTPTestServer> server =
42 HTTPTestServer::CreateServer(L"chrome/test/data", NULL); 42 HTTPTestServer::CreateServer(L"chrome/test/data", NULL);
43 ASSERT_TRUE(NULL != server.get()); 43 ASSERT_TRUE(NULL != server.get());
44 GURL test_url = server->TestServerPage("files/iframe404.html"); 44 GURL test_url = server->TestServerPage("files/iframe404.html");
45 NavigateToURL(test_url); 45 NavigateToURL(test_url);
46 46
47 // Verify that the url is in the title. Since it's set via Javascript, we 47 // Verify that the url is in the title. Since it's set via Javascript, we
48 // need to give it a chance to run. 48 // need to give it a chance to run.
49 int i; 49 int i;
50 std::wstring title; 50 std::wstring title;
51 for (i = 0; i < 10; ++i) { 51 for (i = 0; i < 10; ++i) {
52 Sleep(sleep_timeout_ms()); 52 PlatformThread::Sleep(sleep_timeout_ms());
53 title = GetActiveTabTitle(); 53 title = GetActiveTabTitle();
54 if (title == L"SUCCESS") { 54 if (title == L"SUCCESS") {
55 // Success, bail out. 55 // Success, bail out.
56 break; 56 break;
57 } 57 }
58 } 58 }
59 59
60 if (i == 10) { 60 if (i == 10) {
61 FAIL() << "iframe 404 didn't load properly"; 61 FAIL() << "iframe 404 didn't load properly";
62 } 62 }
63 }; 63 };
OLDNEW
« no previous file with comments | « chrome/browser/download/save_page_uitest.cc ('k') | chrome/browser/printing/printing_layout_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698