Issue 6309017: Removed the JID check from PushNotificationsListenTask::IsValidNotification. ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6309017: Removed the JID check from PushNotificationsListenTask::IsValidNotification. ... (Closed)

Created:
9 years, 11 months ago by sanjeevr

Modified:
9 years, 7 months ago

Reviewers:
akalin

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Removed the JID check from PushNotificationsListenTask::IsValidNotification. This was causing issues because the case did not match in some instances. We could do a case-insensitive check but we really do not need to check the TO: JID here. BUG=None TEST=Cloud Printing should work with users who signed up for Gmail specifying a non-lowercase username. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72612

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	jingle/notifier/listener/push_notifications_listen_task.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

On 2011/01/26 02:50:20, sanjeevr wrote:

Expand Messages | Collapse Messages