Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: jingle/notifier/listener/push_notifications_listen_task.cc

Issue 6309017: Removed the JID check from PushNotificationsListenTask::IsValidNotification. ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: jingle/notifier/listener/push_notifications_listen_task.cc
===================================================================
--- jingle/notifier/listener/push_notifications_listen_task.cc (revision 72357)
+++ jingle/notifier/listener/push_notifications_listen_task.cc (working copy)
@@ -92,8 +92,9 @@
// <data>{base-64 data}</data>
// </push>
// </message>
- return ((stanza->Name() == buzz::QN_MESSAGE) &&
- (stanza->Attr(buzz::QN_TO) == GetClient()->jid().Str()));
+ // We don't do much validation here, just check if the stanza is a message
+ // stanza.
+ return (stanza->Name() == buzz::QN_MESSAGE);
}
} // namespace notifier
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698