Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 6309004: Relax verification of JSFunction result caches. (Closed)

Created:
9 years, 11 months ago by antonm
Modified:
9 years, 4 months ago
Reviewers:
Vitaly Repeshko
CC:
v8-dev
Visibility:
Public.

Description

Relax verification of JSFunction result caches. As invocation of a functin may trigger GC and hence clear all the caches, it's hard to ensure previous invariants. Current invariant is both a key and a value should be the holes or not holes. Committed: http://code.google.com/p/v8/source/detail?r=6338

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M src/objects-debug.cc View 1 chunk +5 lines, -6 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
antonm
Vitaly, may you have a look?
9 years, 11 months ago (2011-01-14 18:02:24 UTC) #1
Vitaly Repeshko
9 years, 11 months ago (2011-01-14 21:22:27 UTC) #2
Can we avoid breaking the (old nice) invariant by setting the cache size only
after calling the factory function? (The generated code in the classic backend
seems to do exactly this so it seems like the only place to fix is
Runtime_GetFromCache.) Otherwise, LGTM.

http://codereview.chromium.org/6309004/diff/1/src/objects-debug.cc
File src/objects-debug.cc (right):

http://codereview.chromium.org/6309004/diff/1/src/objects-debug.cc#newcode666
src/objects-debug.cc:666: int size = Smi::cast(get(kCacheSizeIndex))->value();
Probably needs USE(size) now.

Powered by Google App Engine
This is Rietveld 408576698