Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Unified Diff: src/objects-debug.cc

Issue 6309004: Relax verification of JSFunction result caches. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects-debug.cc
diff --git a/src/objects-debug.cc b/src/objects-debug.cc
index a3552c719ede7a4213539eac55ded174756b1423..7d50bfb6f6ded8baee3b513d2f242314f4d10be3 100644
--- a/src/objects-debug.cc
+++ b/src/objects-debug.cc
@@ -674,13 +674,12 @@ void JSFunctionResultCache::JSFunctionResultCacheVerify() {
ASSERT_EQ(0, finger % kEntrySize);
if (FLAG_enable_slow_asserts) {
- for (int i = kEntriesIndex; i < size; i++) {
- ASSERT(!get(i)->IsTheHole());
- get(i)->Verify();
- }
- for (int i = size; i < length(); i++) {
- ASSERT(get(i)->IsTheHole());
+ STATIC_ASSERT(2 == kEntrySize);
+ for (int i = kEntriesIndex; i < length(); i += kEntrySize) {
get(i)->Verify();
+ get(i + 1)->Verify();
+ // Key and value must be either both the holes, or not.
+ ASSERT(get(i)->IsTheHole() == get(i + 1)->IsTheHole());
}
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698