Issue 6309002: Further tweaks to the passphrase UI to deal with passphrase entry....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6309002: Further tweaks to the passphrase UI to deal with passphrase entry.... (Closed)

Created:
9 years, 11 months ago by John Gregg

Modified:
9 years ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews, Raghu Simha, ncarter (slow), tim (not reviewing), idana, tmccoy

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Further tweaks to the passphrase UI to deal with passphrase entry. BUG=62103 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71381

Patch Set 1 #

Patch Set 2 : LOG(INFO)s removed #

Total comments: 1

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+124 lines, -56 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 2	4 chunks	+14 lines, -5 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.h	View		4 chunks	+24 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.cc	View	1	6 chunks	+17 lines, -4 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_password_unittest.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/resources/configure.html	View	1 2 3 4 5	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/resources/passphrase.html	View	1 2 3 4	5 chunks	+33 lines, -12 lines	0 comments	Download
M	chrome/browser/sync/sync_setup_flow.h	View	1 2	1 chunk	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/sync_setup_flow.cc	View	1 2 3 4 5	4 chunks	+12 lines, -16 lines	0 comments	Download
M	chrome/browser/sync/sync_setup_wizard.cc	View		1 chunk	+7 lines, -3 lines	0 comments	Download
M	chrome/test/live_sync/two_client_live_passwords_sync_test.cc	View	1 2 3	5 chunks	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tim (not reviewing)

9 years, 11 months ago (2011-01-13 21:31:58 UTC) #2

LGTM with nit

http://codereview.chromium.org/6309002/diff/8001/chrome/browser/sync/sync_set...
File chrome/browser/sync/sync_setup_flow.h (right):

http://codereview.chromium.org/6309002/diff/8001/chrome/browser/sync/sync_set...
chrome/browser/sync/sync_setup_flow.h:112: void OnFirstPassphraseEntry(const
std::string& option,
Could you add a comment here to distinguish these two entry methods?  Does
'first' correspond to a specific piece of UI or just physically the first time?

Expand Messages | Collapse Messages