Issue 63058: Fixed step in handling for function.call

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 63058: Fixed step in handling for function.call (Closed)

Created:
11 years, 8 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fixed step in handling for function.call. For function.call debug step in did not work as execution did not break in the function called. This has now been fixed using the same means as for function.apply in CL http://codereview.chromium.org/63055. Committed: http://code.google.com/p/v8/source/detail?r=1684

Patch Set 1 #

Total comments: 1

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -9 lines)			Patch
	M	src/debug.cc	View		1 chunk	+12 lines, -9 lines	1 comment	Download
	M	test/cctest/test-debug.cc	View		1 chunk	+51 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

11 years, 8 months ago (2009-04-07 12:15:14 UTC) #2

LGTM.

http://codereview.chromium.org/63058/diff/1/3
File src/debug.cc (right):

http://codereview.chromium.org/63058/diff/1/3#newcode1163
Line 1163: if (function->shared()->code() ==
How about caching function->shared()->code() in a local variable? It makes it a
tiny bit easier to read.

Expand Messages | Collapse Messages