Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 63055: Fixed the step in handling for function.apply (Closed)

Created:
11 years, 8 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Fixed the step in handling for function.apply. The generic step-in mechanism floods the function called with break points to ensure a break is hit when entering the function. This generic mechanism was also used for function.apply. The code for function.apply contains a keyed load IC which was patched when stepping into function.apply. However function.apply enteres an internal frame not a JavaScript frame. This caused the logic for returning from the break in function.apply to fail as it forced a jump to the IC on the top JavaScript frame. The top JavaScript frame was the frame for the function calling function.apply not the frame for the apply function. Now returning from the break point in the keyed load IC in the apply code caused a jump to the code for the call IC for the function calling function.apply in the first place. Not a pretty sight. Step-in now handles function.apply as a separate case where the actual JavaScript function called through apply is flodded with breakpoints instead of the function.apply function. BUG=269 8210 @chromium.org">BUG=8210 @chromium.org Committed: http://code.google.com/p/v8/source/detail?r=1683

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -53 lines) Patch
M src/debug.cc View 1 chunk +22 lines, -1 line 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +39 lines, -0 lines 0 comments Download
D test/mjsunit/bugs/bug-269.js View 1 chunk +0 lines, -49 lines 0 comments Download
M test/mjsunit/mjsunit.status View 2 chunks +1 line, -4 lines 0 comments Download
A + test/mjsunit/regress/regress-269.js View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
11 years, 8 months ago (2009-04-07 09:41:42 UTC) #1
Kasper Lund
11 years, 8 months ago (2009-04-07 09:51:51 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698