Issue 6304013: Fix regression in submenus not working.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6304013: Fix regression in submenus not working. (Closed)

Created:
9 years, 11 months ago by jam

Modified:
9 years, 7 months ago

Reviewers:
asargent_no_longer_on_chrome

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix regression in submenus not working. BUG=69797 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72005

Patch Set 1 #

Total comments: 2

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -2 lines)			Patch
	M	views/controls/menu/native_menu_win.cc	View		2 chunks	+15 lines, -2 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

asargent_no_longer_on_chrome

lgtm http://codereview.chromium.org/6304013/diff/1/views/controls/menu/native_menu_win.cc File views/controls/menu/native_menu_win.cc (right): http://codereview.chromium.org/6304013/diff/1/views/controls/menu/native_menu_win.cc#newcode127 views/controls/menu/native_menu_win.cc:127: NativeMenuWin* intergoat = GetNativeMenuWinFromHMENU(menu); Does the name "intergoat" ...

9 years, 11 months ago (2011-01-20 19:56:57 UTC) #2

jam

9 years, 11 months ago (2011-01-20 20:24:30 UTC) #3

http://codereview.chromium.org/6304013/diff/1/views/controls/menu/native_menu...
File views/controls/menu/native_menu_win.cc (right):

http://codereview.chromium.org/6304013/diff/1/views/controls/menu/native_menu...
views/controls/menu/native_menu_win.cc:127: NativeMenuWin* intergoat =
GetNativeMenuWinFromHMENU(menu);
On 2011/01/20 19:56:57, Antony Sargent wrote:
> Does the name "intergoat" actually mean something in some idiom I'm not
familiar
> with, or does it somehow derive from the "goats teleported" column of the task
> manager? :)

I think it's an inside joke :)  This is just resurrecting code that I deleted in
my earlier change.

Expand Messages | Collapse Messages