Fix regression in submenus not working.

views/controls/menu/native_menu_win.cc

Index: views/controls/menu/native_menu_win.cc
===================================================================
--- views/controls/menu/native_menu_win.cc	(revision 71973)
+++ views/controls/menu/native_menu_win.cc	(working copy)
@@ -88,6 +88,14 @@
     registered = true;
   }
 
+  NativeMenuWin* GetNativeMenuWinFromHMENU(HMENU hmenu) const {
+    MENUINFO mi = {0};
+    mi.cbSize = sizeof(mi);
+    mi.fMask = MIM_MENUDATA | MIM_STYLE;
+    GetMenuInfo(hmenu, &mi);
+    return reinterpret_cast<NativeMenuWin*>(mi.dwMenuData);
+  }
+
   // Converts the WPARAM value passed to WM_MENUSELECT into an index
   // corresponding to the menu item that was selected.
   int GetMenuItemIndexFromWPARAM(HMENU menu, WPARAM w_param) const {
@@ -116,15 +124,20 @@
 
   // Called when the user selects a specific item.
   void OnMenuCommand(int position, HMENU menu) {
-    parent_->model_->ActivatedAt(position);
+    NativeMenuWin* intergoat = GetNativeMenuWinFromHMENU(menu);

[asargent_no_longer_on_chrome, 2011/01/20 19:56:57]

Does the name "intergoat" actually mean something in some idiom I'm not familiar
with, or does it somehow derive from the "goats teleported" column of the task
manager? :)

[jam, 2011/01/20 20:24:30]

I think it's an inside joke :)  This is just resurrecting code that I deleted in
my earlier change.

+    ui::MenuModel* model = intergoat->model_;
+    model->ActivatedAt(position);
   }
 
   // Called as the user moves their mouse or arrows through the contents of the
   // menu.
   void OnMenuSelect(WPARAM w_param, HMENU menu) {
+    if (!menu)
+      return;  // menu is null when closing on XP.
+
     int position = GetMenuItemIndexFromWPARAM(menu, w_param);
     if (position >= 0)
-      parent_->model_->HighlightChangedTo(position);
+      GetNativeMenuWinFromHMENU(menu)->model_->HighlightChangedTo(position);
   }
 
   // Called by Windows to measure the size of an owner-drawn menu item.