Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 63011: Monster FilePath patch! (Closed)

Created:
11 years, 8 months ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
Reviewers:
Dean McNamee
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Switching things to FilePath: Remove following deprecated wstring-using functions: net/net_util: FilePathToFileURL net/net_util: FileURLToFilePath Switch net/base/upload_data to FilePath. Switch upload-related parts of net/url_request/url_request to FilePath. Made necessary adjustments in rest of code (a lot). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13242

Patch Set 1 #

Patch Set 2 : sync with trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -282 lines) Patch
M chrome/browser/automation/url_request_mock_http_job.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/automation/url_request_mock_net_error_job.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/browser.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_uitest.cc View 7 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/chrome_plugin_host.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/crash_recovery_uitest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/download/download_manager.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/download/save_package.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/user_script_master.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/redirect_uitest.cc View 6 chunks +12 lines, -10 lines 0 comments Download
M chrome/browser/iframe_uitest.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/metrics/metrics_service_uitest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/renderer_security_policy.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/tab_restore_uitest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/views/constrained_window_impl_interactive_uitest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/common/render_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/render_messages_internal.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/resource_dispatcher.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/plugin/chrome_plugin_host.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/renderer/render_view.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/accessibility/accessibility_tests.cc View 6 chunks +12 lines, -12 lines 0 comments Download
M chrome/test/automation/automation_proxy_uitest.cc View 10 chunks +24 lines, -24 lines 0 comments Download
M chrome/test/plugin/plugin_test.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/test/selenium/selenium_test.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/test/tab_switching/tab_switching_test.cc View 1 chunk +9 lines, -10 lines 0 comments Download
M chrome/test/ui/layout_plugin_uitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/ui/ui_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/net_util.h View 1 chunk +0 lines, -4 lines 0 comments Download
M net/base/net_util.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M net/base/net_util_unittest.cc View 4 chunks +48 lines, -47 lines 0 comments Download
M net/base/upload_data.h View 5 chunks +7 lines, -6 lines 0 comments Download
M net/base/upload_data_stream.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M net/url_request/url_request.h View 2 chunks +3 lines, -2 lines 0 comments Download
M net/url_request/url_request.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_file_job.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_unittest.cc View 5 chunks +13 lines, -12 lines 0 comments Download
M webkit/glue/chrome_client_impl.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M webkit/glue/context_menu_unittest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M webkit/glue/dom_operations_unittest.cc View 4 chunks +15 lines, -17 lines 0 comments Download
M webkit/glue/dom_serializer_unittest.cc View 9 chunks +28 lines, -22 lines 0 comments Download
M webkit/glue/iframe_redirect_unittest.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M webkit/glue/plugins/plugin_host.cc View 1 chunk +3 lines, -1 line 0 comments Download
M webkit/glue/resource_handle_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/resource_loader_bridge.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/glue/weburlrequest_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/glue/webview_delegate.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M webkit/tools/test_shell/simple_resource_loader_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_test.h View 3 chunks +6 lines, -3 lines 0 comments Download
M webkit/tools/test_shell/test_shell_test.cc View 2 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
Sorry for the huge patch. I removed one or two things from net/net_util.h and that's ...
11 years, 8 months ago (2009-04-06 14:46:32 UTC) #1
Paweł Hajdan Jr.
Patch updated.
11 years, 8 months ago (2009-04-07 09:59:31 UTC) #2
Dean McNamee
11 years, 8 months ago (2009-04-07 10:12:53 UTC) #3
LG, gnarly

Powered by Google App Engine
This is Rietveld 408576698