Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: chrome/test/accessibility/accessibility_tests.cc

Issue 63011: Monster FilePath patch! (Closed)
Patch Set: sync with trunk Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/render_view.h ('k') | chrome/test/automation/automation_proxy_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/accessibility/accessibility_tests.cc
diff --git a/chrome/test/accessibility/accessibility_tests.cc b/chrome/test/accessibility/accessibility_tests.cc
index bc42dbc6c3cb9254f8b90c9b8dda1ee279e39f46..542ba7f9ea431ace9f3ec2535b49de260b6005cb 100644
--- a/chrome/test/accessibility/accessibility_tests.cc
+++ b/chrome/test/accessibility/accessibility_tests.cc
@@ -140,8 +140,8 @@ TEST_F(AccessibilityTest, DISABLED_TestBackBtnStatusOnNewTab) {
// Set URL and check button status.
scoped_ptr<TabProxy> tab1(window->GetTab(0));
ASSERT_TRUE(tab1.get());
- std::wstring test_file1 = test_data_directory_;
- file_util::AppendToPath(&test_file1, L"title1.html");
+ FilePath test_file1(FilePath::FromWStringHack(test_data_directory_));
+ test_file1 = test_file1.AppendASCII("title1.html");
tab1->NavigateToURL(net::FilePathToFileURL(test_file1));
Sleep(sleep_timeout_ms());
EXPECT_EQ(STATE_SYSTEM_HASPOPUP | STATE_SYSTEM_FOCUSABLE,
@@ -167,8 +167,8 @@ TEST_F(AccessibilityTest, DISABLED_TestBackBtnStatusOnNewTab) {
// Add new tab with URL and check status.
ASSERT_TRUE(window->GetTabCount(&tab_count));
- std::wstring test_file2 = test_data_directory_;
- file_util::AppendToPath(&test_file2, L"title1.html");
+ FilePath test_file2(FilePath::FromWStringHack(test_data_directory_));
+ test_file2 = test_file2.AppendASCII("title1.html");
ASSERT_TRUE(window->AppendTab(net::FilePathToFileURL(test_file2)));
ASSERT_TRUE(window->WaitForTabCountToBecome(tab_count + 1,
action_max_timeout_ms()));
@@ -242,8 +242,8 @@ TEST_F(AccessibilityTest, DISABLED_TestForwardBtnStatusOnNewTab) {
// Set URL and check button status.
scoped_ptr<TabProxy> tab1(window->GetTab(0));
ASSERT_TRUE(tab1.get());
- std::wstring test_file1 = test_data_directory_;
- file_util::AppendToPath(&test_file1, L"title1.html");
+ FilePath test_file1(FilePath::FromWStringHack(test_data_directory_));
+ test_file1 = test_file1.AppendASCII("title1.html");
tab1->NavigateToURL(net::FilePathToFileURL(test_file1));
Sleep(sleep_timeout_ms());
EXPECT_EQ(STATE_SYSTEM_HASPOPUP |
@@ -275,8 +275,8 @@ TEST_F(AccessibilityTest, DISABLED_TestForwardBtnStatusOnNewTab) {
// Add new tab with URL and check status.
ASSERT_TRUE(window->GetTabCount(&tab_count));
- std::wstring test_file2 = test_data_directory_;
- file_util::AppendToPath(&test_file2, L"title1.html");
+ FilePath test_file2(FilePath::FromWStringHack(test_data_directory_));
+ test_file2 = test_file2.AppendASCII("title1.html");
ASSERT_TRUE(window->AppendTab(net::FilePathToFileURL(test_file2)));
ASSERT_TRUE(window->WaitForTabCountToBecome(tab_count + 1,
action_max_timeout_ms()));
@@ -328,8 +328,8 @@ TEST_F(AccessibilityTest, DISABLED_TestStarBtnStatusOnNewTab) {
// Set URL and check button status.
scoped_ptr<TabProxy> tab1(window->GetTab(0));
ASSERT_TRUE(tab1.get());
- std::wstring test_file1 = test_data_directory_;
- file_util::AppendToPath(&test_file1, L"title1.html");
+ FilePath test_file1(FilePath::FromWStringHack(test_data_directory_));
+ test_file1 = test_file1.AppendASCII("title1.html");
tab1->NavigateToURL(net::FilePathToFileURL(test_file1));
Sleep(sleep_timeout_ms());
EXPECT_EQ(STATE_SYSTEM_FOCUSABLE, GetState(acc_obj));
@@ -346,8 +346,8 @@ TEST_F(AccessibilityTest, DISABLED_TestStarBtnStatusOnNewTab) {
// Add new tab with URL and check status.
ASSERT_TRUE(window->GetTabCount(&tab_count));
- std::wstring test_file2 = test_data_directory_;
- file_util::AppendToPath(&test_file2, L"title1.html");
+ FilePath test_file2(FilePath::FromWStringHack(test_data_directory_));
+ test_file2 = test_file2.AppendASCII("title1.html");
ASSERT_TRUE(window->AppendTab(net::FilePathToFileURL(test_file2)));
ASSERT_TRUE(window->WaitForTabCountToBecome(tab_count + 1,
action_max_timeout_ms()));
« no previous file with comments | « chrome/renderer/render_view.h ('k') | chrome/test/automation/automation_proxy_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698