Issue 6299016: Fix logic in a CHECK(), which was missing a ! .

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6299016: Fix logic in a CHECK(), which was missing a ! . (Closed)

Created:
9 years, 11 months ago by Sam Kerner (Chrome)

Modified:
9 years, 7 months ago

Reviewers:
rohitrao (ping after 24h)

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org

Base URL:
http://git.chromium.org/git/chromium.git

Visibility:
Public.

Fix logic in a CHECK(), which was missing a ! . BUG=70636 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72413

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/browser/extensions/external_pref_extension_loader.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 1 (0 generated)

rohitrao (ping after 24h)

9 years, 11 months ago (2011-01-24 22:06:58 UTC) #1

LGTM

If CHECK_IF() exists, that might be clearer.