Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Unified Diff: chrome/browser/extensions/external_pref_extension_loader.cc

Issue 6299016: Fix logic in a CHECK(), which was missing a ! . (Closed) Base URL: http://git.chromium.org/git/chromium.git
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/external_pref_extension_loader.cc
diff --git a/chrome/browser/extensions/external_pref_extension_loader.cc b/chrome/browser/extensions/external_pref_extension_loader.cc
index 25ec50073d660e5c23ce79c6b8f44359a0db9b0c..a3e6bbdbe46853852ff8cf49aecee2df0e44da34 100644
--- a/chrome/browser/extensions/external_pref_extension_loader.cc
+++ b/chrome/browser/extensions/external_pref_extension_loader.cc
@@ -85,8 +85,9 @@ void ExternalPrefExtensionLoader::LoadOnFileThread() {
// If we have any records to process, then we must have
// read the .json file. If we read the .json file, then
- // we were able to set |base_path_|.
- CHECK(!prefs_->empty() || !base_path_.empty());
+ // we were able to set |base_path_|. So, prefs_ is empty,
+ // or base_path_ is not empty.
+ CHECK(prefs_->empty() || !base_path_.empty());
BrowserThread::PostTask(
BrowserThread::UI, FROM_HERE,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698