Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1331)

Unified Diff: chrome/browser/dom_ui/options/password_manager_handler.h

Issue 6299014: DOMUI: Cancel pending queries to the PasswordStore on destruction to avoid (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/dom_ui/options/password_manager_handler.h
diff --git a/chrome/browser/dom_ui/options/password_manager_handler.h b/chrome/browser/dom_ui/options/password_manager_handler.h
index 5cd3080c1a27dce236b065425e68e58cc4ec0f46..c86d7ae8742940f8f97bcaeeefd7f0b3ffb7cbfa 100644
--- a/chrome/browser/dom_ui/options/password_manager_handler.h
+++ b/chrome/browser/dom_ui/options/password_manager_handler.h
@@ -56,10 +56,8 @@ class PasswordManagerHandler : public OptionsPageUIHandler {
// A short class to mediate requests to the password store.
class ListPopulater : public PasswordStoreConsumer {
public:
- explicit ListPopulater(PasswordManagerHandler* page)
- : page_(page),
- pending_login_query_(0) {
- }
+ explicit ListPopulater(PasswordManagerHandler* page);
+ virtual ~ListPopulater();
// Send a query to the password store to populate a list.
virtual void Populate() = 0;
@@ -76,9 +74,7 @@ class PasswordManagerHandler : public OptionsPageUIHandler {
// A short class to mediate requests to the password store for passwordlist.
class PasswordListPopulater : public ListPopulater {
public:
- explicit PasswordListPopulater(PasswordManagerHandler* page)
- : ListPopulater(page) {
- }
+ explicit PasswordListPopulater(PasswordManagerHandler* page);
// Send a query to the password store to populate a password list.
virtual void Populate();
@@ -91,9 +87,7 @@ class PasswordManagerHandler : public OptionsPageUIHandler {
// A short class to mediate requests to the password store for exceptions.
class PasswordExceptionListPopulater : public ListPopulater {
public:
- explicit PasswordExceptionListPopulater(
- PasswordManagerHandler* page) : ListPopulater(page) {
- }
+ explicit PasswordExceptionListPopulater(PasswordManagerHandler* page);
// Send a query to the password store to populate a passwordException list.
virtual void Populate();

Powered by Google App Engine
This is Rietveld 408576698