DOMUI: Cancel pending queries to the PasswordStore on destruction to avoid

chrome/browser/dom_ui/options/password_manager_handler.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.

[csilv, 2011/01/21 02:18:21]

Bump copyright date

[James Hawkins, 2011/01/21 02:21:50]

Done.

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_DOM_UI_OPTIONS_PASSWORD_MANAGER_HANDLER_H_
 #define CHROME_BROWSER_DOM_UI_OPTIONS_PASSWORD_MANAGER_HANDLER_H_
 
 #include <string>
 #include <vector>
 
 #include "chrome/browser/dom_ui/options/options_ui.h"
@@ skipping 37 matching lines @@
   void ShowSelectedPassword(const ListValue* args);
 
   // Sets the password and exception list contents to the given data.
   // We take ownership of the PasswordForms in the vector.
   void SetPasswordList();
   void SetPasswordExceptionList();
 
   // A short class to mediate requests to the password store.
   class ListPopulater : public PasswordStoreConsumer {
    public:
-    explicit ListPopulater(PasswordManagerHandler* page)
-        : page_(page),
-          pending_login_query_(0) {
-    }
+    explicit ListPopulater(PasswordManagerHandler* page);
+    virtual ~ListPopulater();
 
     // Send a query to the password store to populate a list.
     virtual void Populate() = 0;
 
     // Send the password store's reply back to the handler.
     virtual void OnPasswordStoreRequestDone(
         int handle, const std::vector<webkit_glue::PasswordForm*>& result) = 0;
 
    protected:
     PasswordManagerHandler* page_;
     int pending_login_query_;
   };
 
   // A short class to mediate requests to the password store for passwordlist.
   class PasswordListPopulater : public ListPopulater {
    public:
-    explicit PasswordListPopulater(PasswordManagerHandler* page)
-      : ListPopulater(page) {
-    }
+    explicit PasswordListPopulater(PasswordManagerHandler* page);
 
     // Send a query to the password store to populate a password list.
     virtual void Populate();
 
     // Send the password store's reply back to the handler.
     virtual void OnPasswordStoreRequestDone(
         int handle, const std::vector<webkit_glue::PasswordForm*>& result);
   };
 
   // A short class to mediate requests to the password store for exceptions.
   class PasswordExceptionListPopulater : public ListPopulater {
    public:
-    explicit PasswordExceptionListPopulater(
-        PasswordManagerHandler* page) : ListPopulater(page) {
-    }
+    explicit PasswordExceptionListPopulater(PasswordManagerHandler* page);
 
     // Send a query to the password store to populate a passwordException list.
     virtual void Populate();
 
     // Send the password store's reply back to the handler.
     virtual void OnPasswordStoreRequestDone(
         int handle, const std::vector<webkit_glue::PasswordForm*>& result);
   };
 
   // Password store consumer for populating the password list and exceptions.
   PasswordListPopulater populater_;
   PasswordExceptionListPopulater exception_populater_;
 
   std::vector<webkit_glue::PasswordForm*> password_list_;
   std::vector<webkit_glue::PasswordForm*> password_exception_list_;
 
   // User's pref
   std::string languages_;
 
   DISALLOW_COPY_AND_ASSIGN(PasswordManagerHandler);
 };
 
 #endif  // CHROME_BROWSER_DOM_UI_OPTIONS_PASSWORD_MANAGER_HANDLER_H_