Issue 6299014: DOMUI: Cancel pending queries to the PasswordStore on destruction to avoid

Issue 6299014: DOMUI: Cancel pending queries to the PasswordStore on destruction to avoid (Closed)

Created:
9 years, 11 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
csilv

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

DOMUI: Cancel pending queries to the PasswordStore on destruction to avoid being notified after the object has been destroyed. BUG=69441 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72092

Patch Set 1 #

Total comments: 4

Patch Set 2 : Bump copyright. #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -12 lines)			Patch
	M	chrome/browser/dom_ui/options/password_manager_handler.h	View	1	4 chunks	+5 lines, -11 lines	0 comments	Download
	M	chrome/browser/dom_ui/options/password_manager_handler.cc	View	1	3 chunks	+19 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

csilv

http://codereview.chromium.org/6299014/diff/1/chrome/browser/dom_ui/options/password_manager_handler.cc File chrome/browser/dom_ui/options/password_manager_handler.cc (right): http://codereview.chromium.org/6299014/diff/1/chrome/browser/dom_ui/options/password_manager_handler.cc#newcode1 chrome/browser/dom_ui/options/password_manager_handler.cc:1: // Copyright (c) 2010 The Chromium Authors. All rights ...

9 years, 11 months ago (2011-01-21 02:18:21 UTC) #3

James Hawkins

9 years, 11 months ago (2011-01-21 02:21:50 UTC) #4

http://codereview.chromium.org/6299014/diff/1/chrome/browser/dom_ui/options/p...
File chrome/browser/dom_ui/options/password_manager_handler.cc (right):

http://codereview.chromium.org/6299014/diff/1/chrome/browser/dom_ui/options/p...
chrome/browser/dom_ui/options/password_manager_handler.cc:1: // Copyright (c)
2010 The Chromium Authors. All rights reserved.
On 2011/01/21 02:18:21, csilv wrote:
> bump copyright date

Done.

http://codereview.chromium.org/6299014/diff/1/chrome/browser/dom_ui/options/p...
File chrome/browser/dom_ui/options/password_manager_handler.h (right):

http://codereview.chromium.org/6299014/diff/1/chrome/browser/dom_ui/options/p...
chrome/browser/dom_ui/options/password_manager_handler.h:1: // Copyright (c)
2010 The Chromium Authors. All rights reserved.
On 2011/01/21 02:18:21, csilv wrote:
> Bump copyright date

Done.

Expand Messages | Collapse Messages