Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6299002: [Sync] Port about:sync to DOMUI (Closed)

Created:
9 years, 11 months ago by akalin
Modified:
9 years, 7 months ago
CC:
chromium-reviews, ncarter (slow), idana, Raghu Simha, arv (Not doing code reviews), pam+watch_chromium.org, tim (not reviewing)
Visibility:
Public.

Description

[Sync] Port about:sync to DOMUI Write chrome://sync-internals DOMUI page which is like about:sync but automatically updates on sync events. Make about:sync{,-internals} aliases for chrome://sync-internals. More diagnostic capabilities will be added to chrome://sync-internals in future CLs. BUG=69500 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71435

Patch Set 1 #

Patch Set 2 : Synced to head #

Patch Set 3 : Added workaround for bug 69633 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+306 lines, -51 lines) Patch
M chrome/browser/browser_about_handler.cc View 1 8 chunks +10 lines, -33 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/dom_ui_factory.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download
A chrome/browser/dom_ui/sync_internals_html_source.h View 1 chunk +31 lines, -0 lines 0 comments Download
A chrome/browser/dom_ui/sync_internals_html_source.cc View 1 chunk +49 lines, -0 lines 0 comments Download
A chrome/browser/dom_ui/sync_internals_message_handler.h View 1 chunk +39 lines, -0 lines 0 comments Download
A chrome/browser/dom_ui/sync_internals_message_handler.cc View 1 chunk +48 lines, -0 lines 0 comments Download
A chrome/browser/dom_ui/sync_internals_ui.h View 1 chunk +21 lines, -0 lines 0 comments Download
A chrome/browser/dom_ui/sync_internals_ui.cc View 1 chunk +30 lines, -0 lines 0 comments Download
A + chrome/browser/resources/sync_internals/sync_index.html View 1 2 5 chunks +24 lines, -14 lines 0 comments Download
A chrome/browser/resources/sync_internals_resources.grd View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
M chrome/browser/sync/sync_ui_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/sync_ui_util.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome.gyp View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/url_constants.h View 1 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/common/url_constants.cc View 1 3 chunks +5 lines, -0 lines 0 comments Download
M tools/grit/resource_ids View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
akalin
+tim for review (the delete of about_sync.html doesn't show up on the code review, for ...
9 years, 11 months ago (2011-01-13 12:57:12 UTC) #1
tim (not reviewing)
LGTM!
9 years, 11 months ago (2011-01-13 23:20:24 UTC) #2
akalin
9 years, 11 months ago (2011-01-14 09:40:37 UTC) #3 
Added workaround for bug 69633, committing as soon as trybots pass.

On 2011/01/13 23:20:24, timsteele wrote:
> LGTM!

Powered by Google App Engine
This is Rietveld 408576698