chrome/browser/sync/sync_ui_util.cc - Issue 6299002: [Sync] Port about:sync to DOMUI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/sync_ui_util.cc

Issue 6299002: [Sync] Port about:sync to DOMUI (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added workaround for bug 69633 Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/sync_ui_util.cc

diff --git a/chrome/browser/sync/sync_ui_util.cc b/chrome/browser/sync/sync_ui_util.cc

index 3f45c38c2eb3617ab8d602ba5111b4ebdb7939c0..3e73fbc30f19187beac956e025ad71f611d6e029 100644

--- a/chrome/browser/sync/sync_ui_util.cc

+++ b/chrome/browser/sync/sync_ui_util.cc

@@ -281,8 +281,8 @@ std::string MakeSyncAuthErrorText(

void ConstructAboutInformation(ProfileSyncService* service,

DictionaryValue* strings) {

- CHECK(strings != NULL);

- if (!service->HasSyncSetupCompleted()) {

+ CHECK(strings);

+ if (!service || !service->HasSyncSetupCompleted()) {

strings->SetString("summary", "SYNC DISABLED");

} else {

sync_api::SyncManager::Status full_status(

« no previous file with comments | « chrome/browser/sync/sync_ui_util.h ('k') | chrome/chrome.gyp » ('j') | no next file with comments »