Issue 6298014: Replace one unfortunate hack with a somewhat better one. The included atlctrl...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6298014: Replace one unfortunate hack with a somewhat better one. The included atlctrl... (Closed)

Created:
9 years, 11 months ago by erikwright (departed)

Modified:
9 years, 7 months ago

Reviewers:
tommi (sloooow) - chröme

CC:
chromium-reviews, amit, robertshield

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Replace one unfortunate hack with a somewhat better one. The included atlctrlx.h relies on min and max macros, which are generally bad and especially so in combination with STL. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72496

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -10 lines)			Patch
	M	chrome_frame/ready_mode/internal/ready_prompt_window.cc	View		2 chunks	+8 lines, -10 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages