Update cros_overlay_list to work from either src/scripts or /usr/bin.

Update cros_overlay_list to work from either src/scripts or /usr/bin.

Change-Id: If4c2852568454c2dccf09b0fc1e180ed228a1bb7

BUG=chromium-os:4230
TEST=run cros_overlay_list from both locations in the chroot and src/scripts outside the chroot.

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=95e56d1

[Greg Spencer (Chromium), 2011-01-26 22:30:45]

http://codereview.chromium.org/6293021/diff/1/bin/cros_overlay_list
File bin/cros_overlay_list (right):

http://codereview.chromium.org/6293021/diff/1/bin/cros_overlay_list#newcode26
bin/cros_overlay_list:26: . "${COMMON_SH}"
So, in my CL for cleaning things up, I've used the following code for this
situation in all the files that look for common.sh (with variations in the
".."'s for where the live).

--
# Find the location of common.sh.  If we're not in the chroot,
# use a path relative to this script's location.
[ -f /usr/lib/crosutils/common.sh ] && \
  SCRIPT_ROOT=/usr/lib/crosutils || \
  SCRIPT_ROOT="$(dirname "$(readlink -f "$0")")/.."

. "${SCRIPT_ROOT}/common.sh
--

The readlink isn't strictly necessary if we're not encouraging people to link to
scripts.

It seems a bit more concise, but gives less error feedback.

[Greg Spencer (Chromium), 2011-01-26 22:32:01]

On 2011/01/26 22:30:45, Greg Spencer (Chromium) wrote:
> . "${SCRIPT_ROOT}/common.sh

(And the missing quote is a cut/paste error. :)

[robotboy, 2011-01-26 23:07:37]

http://codereview.chromium.org/6293021/diff/1/bin/cros_overlay_list
File bin/cros_overlay_list (right):

http://codereview.chromium.org/6293021/diff/1/bin/cros_overlay_list#newcode26
bin/cros_overlay_list:26: . "${COMMON_SH}"
I think I prefer to have the error checking and reporting...  Especially since
this is one script that may continue to be called from both inside and outside
the chroot.  Would you object to my more verbose version here?

Thanks,
    Anton

[Greg Spencer (Chromium), 2011-01-26 23:47:46]

http://codereview.chromium.org/6293021/diff/1/bin/cros_overlay_list
File bin/cros_overlay_list (right):

http://codereview.chromium.org/6293021/diff/1/bin/cros_overlay_list#newcode26
bin/cros_overlay_list:26: . "${COMMON_SH}"
No, that's fine.  I might even adopt some of it for my change, but it does seem
like a lot of boilerplate for each file that uses common.sh.

[robotboy, 2011-01-27 00:03:08]

Yes, I agree.  Hopefully most files will just do ".
/usr/lib/crosutils/common.sh" and that's it.  Only the ones that need to
eventually be runnable outside the chroot (which should be a small minority)
need something more.

Thanks,
    Anton

[robotboy, 2011-01-27 17:01:46]

Ping?

[Mandeep Singh Baines, 2011-01-27 17:29:57]

LGTM