Update cros_overlay_list to work from either src/scripts or /usr/bin.

bin/cros_overlay_list

 #!/bin/bash
 
 # Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This script generates the list of board overlays and variants.
 
-# Load common constants.  This should be the first executable line.
-# The path to common.sh should be relative to your script's location.
-. "$(dirname "$0")/../common.sh"
+# Load common CrOS utilities.  Inside the chroot this file is installed in
+# /usr/lib/crosutils.  Outside the chroot we find it relative to the scripts
+# location.
+common_paths="/usr/lib/crosutils $(dirname "$0")/.."
+
+for path in ${common_paths} ; do
+  if [ -f "${path}/common.sh" ] ; then
+    COMMON_SH="${path}/common.sh"
+    break
+  fi
+done
+
+if [ -z "${COMMON_SH}" ] ; then
+  error "common.sh not found in search path (${common_paths})"
+  exit 1
+fi
+
+. "${COMMON_SH}"

[Greg Spencer (Chromium), 2011/01/26 22:30:45]

So, in my CL for cleaning things up, I've used the following code for this
situation in all the files that look for common.sh (with variations in the
".."'s for where the live).

--
# Find the location of common.sh.  If we're not in the chroot,
# use a path relative to this script's location.
[ -f /usr/lib/crosutils/common.sh ] && \
  SCRIPT_ROOT=/usr/lib/crosutils || \
  SCRIPT_ROOT="$(dirname "$(readlink -f "$0")")/.."

. "${SCRIPT_ROOT}/common.sh
--

The readlink isn't strictly necessary if we're not encouraging people to link to
scripts.

It seems a bit more concise, but gives less error feedback.

[robotboy, 2011/01/26 23:07:38]

I think I prefer to have the error checking and reporting...  Especially since
this is one script that may continue to be called from both inside and outside
the chroot.  Would you object to my more verbose version here?

Thanks,
    Anton

[Greg Spencer (Chromium), 2011/01/26 23:47:46]

No, that's fine.  I might even adopt some of it for my change, but it does seem
like a lot of boilerplate for each file that uses common.sh.

 
 get_default_board
 
 # Flags
 DEFINE_string board "$DEFAULT_BOARD" "The name of the board to set up."
 DEFINE_string board_overlay "" "Location of the board overlay."
 DEFINE_boolean primary_only ${FLAGS_FALSE} \
   "Only return the path to the board's primary overlay. (Default: false)"
 DEFINE_string variant "" "Board variant."
 
@@ skipping 112 matching lines @@
     fi
   fi
 fi
 
 #
 # Finally, add in any user requested board overlays.
 #
 if [ -d "${FLAGS_board_overlay}" ] ; then
   echo "${FLAGS_board_overlay}"
 fi