Fix DOMUI pref mode handling of Mac menu items

Fix DOMUI pref mode handling of Mac menu items

In DOMUI pref mode, Mac menu items should open prefs via a browser window. Also fixes OpenSyncMyBookmarksDialog on all platforms.

BUG=67670
TEST=Choosing a pref-opening menu item from the Chrome menu on Mac should open DOMUI prefs.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72500

[csilv, 2011-01-25 00:33:50]

http://codereview.chromium.org/6293018/diff/2001/chrome/browser/app_controlle...
File chrome/browser/app_controller_mac.mm (right):

http://codereview.chromium.org/6293018/diff/2001/chrome/browser/app_controlle...
chrome/browser/app_controller_mac.mm:1: // Copyright (c) 2010 The Chromium
Authors. All rights reserved.
bump copyright, here and others.

http://codereview.chromium.org/6293018/diff/2001/chrome/browser/app_controlle...
chrome/browser/app_controller_mac.mm:873:
browser->OpenClearBrowsingDataDialog();
Should be calling OpenImportSettingsDialog();

http://codereview.chromium.org/6293018/diff/2001/chrome/browser/app_controlle...
chrome/browser/app_controller_mac.mm:875:
Browser::OpenClearBrowingDataDialogWindow(defaultProfile);
Should be calling OpenImportSettingsDialogWindow().

http://codereview.chromium.org/6293018/diff/2001/chrome/browser/app_controlle...
chrome/browser/app_controller_mac.mm:926: case IDC_SYNC_BOOKMARKS: {
Any particular reason for adding the brackets to this block?  Just curious.

http://codereview.chromium.org/6293018/diff/2001/chrome/browser/sync/sync_ui_...
File chrome/browser/sync/sync_ui_util.h (right):

http://codereview.chromium.org/6293018/diff/2001/chrome/browser/sync/sync_ui_...
chrome/browser/sync/sync_ui_util.h:57: // incognito).  |code| should be one of
the START_FROM_* codes.
Consider documenting the 'browser' parameter in the comments.

[stuartmorgan, 2011-01-25 01:08:43]

http://codereview.chromium.org/6293018/diff/2001/chrome/browser/app_controlle...
File chrome/browser/app_controller_mac.mm (right):

http://codereview.chromium.org/6293018/diff/2001/chrome/browser/app_controlle...
chrome/browser/app_controller_mac.mm:1: // Copyright (c) 2010 The Chromium
Authors. All rights reserved.
On 2011/01/25 00:33:50, csilv wrote:
> bump copyright, here and others.

Done.

http://codereview.chromium.org/6293018/diff/2001/chrome/browser/app_controlle...
chrome/browser/app_controller_mac.mm:873:
browser->OpenClearBrowsingDataDialog();
On 2011/01/25 00:33:50, csilv wrote:
> Should be calling OpenImportSettingsDialog();

Whoops! Apparently I wasn't looking carefully at the dialog that came up. Done.

http://codereview.chromium.org/6293018/diff/2001/chrome/browser/app_controlle...
chrome/browser/app_controller_mac.mm:875:
Browser::OpenClearBrowingDataDialogWindow(defaultProfile);
On 2011/01/25 00:33:50, csilv wrote:
> Should be calling OpenImportSettingsDialogWindow().

Done.

http://codereview.chromium.org/6293018/diff/2001/chrome/browser/app_controlle...
chrome/browser/app_controller_mac.mm:926: case IDC_SYNC_BOOKMARKS: {
On 2011/01/25 00:33:50, csilv wrote:
> Any particular reason for adding the brackets to this block?  Just curious.

It's cruft from an earlier iteration of the change where I added a variable
declaration, so needed scope. Removed.

http://codereview.chromium.org/6293018/diff/2001/chrome/browser/sync/sync_ui_...
File chrome/browser/sync/sync_ui_util.h (right):

http://codereview.chromium.org/6293018/diff/2001/chrome/browser/sync/sync_ui_...
chrome/browser/sync/sync_ui_util.h:57: // incognito).  |code| should be one of
the START_FROM_* codes.
On 2011/01/25 00:33:50, csilv wrote:
> Consider documenting the 'browser' parameter in the comments.

Done.

[csilv, 2011-01-25 01:11:29]

LGTM

[akalin, 2011-01-25 05:45:00]

LGTM

On 2011/01/25 01:11:29, csilv wrote:
> LGTM