Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Side by Side Diff: chrome/browser/app_controller_mac.mm

Issue 6293018: Fix DOMUI pref mode handling of Mac menu items (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/sync/sync_ui_util.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/app_controller_mac.h" 5 #import "chrome/browser/app_controller_mac.h"
6 6
7 #include "base/auto_reset.h" 7 #include "base/auto_reset.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/file_path.h" 9 #include "base/file_path.h"
10 #include "base/mac/mac_util.h" 10 #include "base/mac/mac_util.h"
11 #include "base/message_loop.h" 11 #include "base/message_loop.h"
(...skipping 829 matching lines...) Expand 10 before | Expand all | Expand 10 after
841 Browser::OpenEmptyWindow(defaultProfile->GetOffTheRecordProfile()); 841 Browser::OpenEmptyWindow(defaultProfile->GetOffTheRecordProfile());
842 break; 842 break;
843 case IDC_RESTORE_TAB: 843 case IDC_RESTORE_TAB:
844 Browser::OpenWindowWithRestoredTabs(defaultProfile); 844 Browser::OpenWindowWithRestoredTabs(defaultProfile);
845 break; 845 break;
846 case IDC_OPEN_FILE: 846 case IDC_OPEN_FILE:
847 CreateBrowser(defaultProfile)->ExecuteCommand(IDC_OPEN_FILE); 847 CreateBrowser(defaultProfile)->ExecuteCommand(IDC_OPEN_FILE);
848 break; 848 break;
849 case IDC_CLEAR_BROWSING_DATA: { 849 case IDC_CLEAR_BROWSING_DATA: {
850 // There may not be a browser open, so use the default profile. 850 // There may not be a browser open, so use the default profile.
851 [ClearBrowsingDataController 851 if (CommandLine::ForCurrentProcess()->HasSwitch(
852 showClearBrowsingDialogForProfile:defaultProfile]; 852 switches::kDisableTabbedOptions)) {
853 [ClearBrowsingDataController
854 showClearBrowsingDialogForProfile:defaultProfile];
855 } else {
856 if (Browser* browser = ActivateBrowser(defaultProfile)) {
857 browser->OpenClearBrowsingDataDialog();
858 } else {
859 Browser::OpenClearBrowingDataDialogWindow(defaultProfile);
860 }
861 }
853 break; 862 break;
854 } 863 }
855 case IDC_IMPORT_SETTINGS: { 864 case IDC_IMPORT_SETTINGS: {
856 UserMetrics::RecordAction(UserMetricsAction("Import_ShowDlg"), 865 if (CommandLine::ForCurrentProcess()->HasSwitch(
857 defaultProfile); 866 switches::kDisableTabbedOptions)) {
858 [ImportSettingsDialogController 867 UserMetrics::RecordAction(UserMetricsAction("Import_ShowDlg"),
859 showImportSettingsDialogForProfile:defaultProfile]; 868 defaultProfile);
869 [ImportSettingsDialogController
870 showImportSettingsDialogForProfile:defaultProfile];
871 } else {
872 if (Browser* browser = ActivateBrowser(defaultProfile)) {
873 browser->OpenImportSettingsDialog();
874 } else {
875 Browser::OpenImportSettingsDialogWindow(defaultProfile);
876 }
877 }
860 break; 878 break;
861 } 879 }
862 case IDC_SHOW_BOOKMARK_MANAGER: 880 case IDC_SHOW_BOOKMARK_MANAGER:
863 UserMetrics::RecordAction(UserMetricsAction("ShowBookmarkManager"), 881 UserMetrics::RecordAction(UserMetricsAction("ShowBookmarkManager"),
864 defaultProfile); 882 defaultProfile);
865 if (Browser* browser = ActivateBrowser(defaultProfile)) { 883 if (Browser* browser = ActivateBrowser(defaultProfile)) {
866 // Open a bookmark manager tab. 884 // Open a bookmark manager tab.
867 browser->OpenBookmarkManager(); 885 browser->OpenBookmarkManager();
868 } else { 886 } else {
869 // No browser window, so create one for the bookmark manager tab. 887 // No browser window, so create one for the bookmark manager tab.
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
911 // 929 //
912 // TODO(akalin,viettrungluu): Figure out whether this method can 930 // TODO(akalin,viettrungluu): Figure out whether this method can
913 // be prevented from being called if defaultProfile is NULL. 931 // be prevented from being called if defaultProfile is NULL.
914 if (!defaultProfile) { 932 if (!defaultProfile) {
915 LOG(WARNING) << "NULL defaultProfile detected -- not doing anything"; 933 LOG(WARNING) << "NULL defaultProfile detected -- not doing anything";
916 break; 934 break;
917 } 935 }
918 // TODO(akalin): Add a constant to denote starting sync from the 936 // TODO(akalin): Add a constant to denote starting sync from the
919 // main menu and use that instead of START_FROM_WRENCH. 937 // main menu and use that instead of START_FROM_WRENCH.
920 sync_ui_util::OpenSyncMyBookmarksDialog( 938 sync_ui_util::OpenSyncMyBookmarksDialog(
921 defaultProfile, ProfileSyncService::START_FROM_WRENCH); 939 defaultProfile, ActivateBrowser(defaultProfile),
940 ProfileSyncService::START_FROM_WRENCH);
922 break; 941 break;
923 case IDC_TASK_MANAGER: 942 case IDC_TASK_MANAGER:
924 UserMetrics::RecordAction(UserMetricsAction("TaskManager"), 943 UserMetrics::RecordAction(UserMetricsAction("TaskManager"),
925 defaultProfile); 944 defaultProfile);
926 TaskManagerMac::Show(); 945 TaskManagerMac::Show();
927 break; 946 break;
928 case IDC_OPTIONS: 947 case IDC_OPTIONS:
929 [self showPreferences:sender]; 948 [self showPreferences:sender];
930 break; 949 break;
931 default: 950 default:
(...skipping 338 matching lines...) Expand 10 before | Expand all | Expand 10 after
1270 [appController showPreferencesWindow:nil page:page profile:profile]; 1289 [appController showPreferencesWindow:nil page:page profile:profile];
1271 } 1290 }
1272 1291
1273 namespace app_controller_mac { 1292 namespace app_controller_mac {
1274 1293
1275 bool IsOpeningNewWindow() { 1294 bool IsOpeningNewWindow() {
1276 return g_is_opening_new_window; 1295 return g_is_opening_new_window;
1277 } 1296 }
1278 1297
1279 } // namespace app_controller_mac 1298 } // namespace app_controller_mac
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/sync/sync_ui_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698